Skip to content

Commit aaf797a

Browse files
Ives van Hoornefacebook-github-bot
Ives van Hoorne
authored andcommitted
Use new config internally in Metro
Summary: Change the internals of Metro to use the new configuration instead of `ServerOptions`. Reviewed By: rafeca Differential Revision: D8734685 fbshipit-source-id: 1215f799419fcaa0e5fb7814683da1cbba96795c
1 parent a32620d commit aaf797a

File tree

3 files changed

+3
-10
lines changed

3 files changed

+3
-10
lines changed

local-cli/bundle/buildBundle.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ const Server = require('metro/src/Server');
1616

1717
/* $FlowFixMe(site=react_native_oss) */
1818
const outputBundle = require('metro/src/shared/output/bundle');
19-
const {convert} = require('metro-config');
2019
const path = require('path');
2120
const saveAssets = require('./saveAssets');
2221

@@ -57,9 +56,7 @@ async function buildBundle(
5756
platform: args.platform,
5857
};
5958

60-
const {serverOptions} = convert.convertNewToOld(config);
61-
62-
const server = new Server(serverOptions);
59+
const server = new Server(config);
6360

6461
try {
6562
const bundle = await output.build(server, requestOpts);

local-cli/dependencies/dependencies.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
'use strict';
1111

1212
const Metro = require('metro');
13-
const {convert} = require('metro-config');
1413

1514
const denodeify = require('denodeify');
1615
const fs = require('fs');
@@ -48,12 +47,10 @@ async function dependencies(argv, configPromise, args, packagerInstance) {
4847
? fs.createWriteStream(args.output)
4948
: process.stdout;
5049

51-
const {serverOptions} = convert.convertNewToOld(config);
52-
5350
return Promise.resolve(
5451
(packagerInstance
5552
? packagerInstance.getOrderedDependencyPaths(options)
56-
: Metro.getOrderedDependencyPaths(serverOptions, options)
53+
: Metro.getOrderedDependencyPaths(config, options)
5754
).then(deps => {
5855
deps.forEach(modulePath => {
5956
// Temporary hack to disable listing dependencies not under this directory.

local-cli/server/runServer.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,7 @@ async function runServer(args: Args, config: ConfigT) {
6060
config.server.enhanceMiddleware = middleware =>
6161
middlewareManager.getConnectInstance().use(middleware);
6262

63-
const serverInstance = await Metro.runServer({
64-
config,
63+
const serverInstance = await Metro.runServer(config, {
6564
host: args.host,
6665
secure: args.https,
6766
secureCert: args.cert,

0 commit comments

Comments
 (0)