reactSetInheritedBackgroundColor was removed from RCTView

shergin · facebook-github-bot · commit b8e60a3ca331 · 2017-12-18T11:47:26.000-08:00
Summary:
Now setting explicit backgroundColor style is required for Views with background shadow,
otherwise the shadow will be generated based on content of the view (which is expected behaviour).

Reviewed By: mmmulani

Differential Revision: D6582587

fbshipit-source-id: 0514cb3c57bad17d2af40810b0e0f7ddc96a2c31
diff --git a/React/Views/RCTView.m b/React/Views/RCTView.m
@@ -691,14 +691,6 @@ static BOOL RCTLayerHasShadow(CALayer *layer)
   return layer.shadowOpacity * CGColorGetAlpha(layer.shadowColor) > 0;
 }
 
-- (void)reactSetInheritedBackgroundColor:(UIColor *)inheritedBackgroundColor
-{
-  // Inherit background color if a shadow has been set, as an optimization
-  if (RCTLayerHasShadow(self.layer)) {
-    self.backgroundColor = inheritedBackgroundColor;
-  }
-}
-
 static void RCTUpdateShadowPathForView(RCTView *view)
 {
   if (RCTLayerHasShadow(view.layer)) {

Original file line number	Diff line number	Diff line change
`@@ -691,14 +691,6 @@ static BOOL RCTLayerHasShadow(CALayer *layer)`
`691`	`691`	`return layer.shadowOpacity * CGColorGetAlpha(layer.shadowColor) > 0;`
`692`	`692`	`}`
`693`	`693`
`694`		`-- (void)reactSetInheritedBackgroundColor:(UIColor *)inheritedBackgroundColor`
`695`		`-{`
`696`		`- // Inherit background color if a shadow has been set, as an optimization`
`697`		`- if (RCTLayerHasShadow(self.layer)) {`
`698`		`- self.backgroundColor = inheritedBackgroundColor;`
`699`		`- }`
`700`		`-}`
`701`		`-`
`702`	`694`	`static void RCTUpdateShadowPathForView(RCTView *view)`
`703`	`695`	`{`
`704`	`696`	`if (RCTLayerHasShadow(view.layer)) {`