Skip to content

Commit ba0c3ff

Browse files
dulmandakhfacebook-github-bot
authored andcommitted
ReactTextView extends AppCompatTextView (#23321)
Summary: Google recommends to use AppCompat widgets, and this PR changes ReactTextView to extend AppCompatTextView. [Android] [Changed] - ReactTextView extends AppCompatTextView Pull Request resolved: #23321 Differential Revision: D13986149 Pulled By: cpojer fbshipit-source-id: 878849fff12dc5478bb0d0952b2c22695391e81a
1 parent bca8510 commit ba0c3ff

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ rn_android_library(
99
],
1010
deps = [
1111
YOGA_TARGET,
12+
react_native_dep("third-party/android/support/v4:lib-support-v4"),
13+
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
1214
react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"),
1315
react_native_dep("third-party/java/infer-annotations:infer-annotations"),
1416
react_native_dep("third-party/java/jsr-305:jsr-305"),

ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,21 +10,21 @@
1010
import android.content.Context;
1111
import android.graphics.drawable.Drawable;
1212
import android.os.Build;
13+
import android.support.v7.widget.AppCompatTextView;
1314
import android.text.Layout;
1415
import android.text.Spannable;
1516
import android.text.Spanned;
1617
import android.text.TextUtils;
1718
import android.view.Gravity;
1819
import android.view.ViewGroup;
19-
import android.widget.TextView;
2020
import com.facebook.common.logging.FLog;
2121
import com.facebook.react.common.ReactConstants;
2222
import com.facebook.react.uimanager.ReactCompoundView;
2323
import com.facebook.react.uimanager.ViewDefaults;
2424
import com.facebook.react.views.view.ReactViewBackgroundManager;
2525
import javax.annotation.Nullable;
2626

27-
public class ReactTextView extends TextView implements ReactCompoundView {
27+
public class ReactTextView extends AppCompatTextView implements ReactCompoundView {
2828

2929
private static final ViewGroup.LayoutParams EMPTY_LAYOUT_PARAMS =
3030
new ViewGroup.LayoutParams(0, 0);

0 commit comments

Comments
 (0)