Skip to content

Commit bf0a95d

Browse files
Ravi Bhoraskarfacebook-github-bot
Ravi Bhoraskar
authored andcommitted
Backed out changeset 8841a5719494 (D4944482)
Reviewed By: sahrens Differential Revision: D4981286 fbshipit-source-id: 5b17ba93ee43a0a46f98f47b6fb8a779180ab4b6
1 parent 366c15d commit bf0a95d

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

Diff for: ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java

+1-12
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@
2828
import android.view.Gravity;
2929
import android.view.KeyEvent;
3030
import android.view.View;
31-
import android.view.ViewTreeObserver;
3231
import android.view.inputmethod.EditorInfo;
3332
import android.widget.TextView;
3433

@@ -92,23 +91,13 @@ public String getName() {
9291

9392
@Override
9493
public ReactEditText createViewInstance(ThemedReactContext context) {
95-
final ReactEditText editText = new ReactEditText(context);
94+
ReactEditText editText = new ReactEditText(context);
9695
int inputType = editText.getInputType();
9796
editText.setInputType(inputType & (~InputType.TYPE_TEXT_FLAG_MULTI_LINE));
9897
editText.setReturnKeyType("done");
9998
editText.setTextSize(
10099
TypedValue.COMPLEX_UNIT_PX,
101100
(int) Math.ceil(PixelUtil.toPixelFromSP(ViewDefaults.FONT_SIZE_SP)));
102-
// Fixes an issue where the EditText is not selectable if nested within a
103-
// ViewPagerAndroid on some versions of Android (API 16, 23)
104-
editText.getViewTreeObserver().addOnPreDrawListener(new ViewTreeObserver.OnPreDrawListener() {
105-
@Override
106-
public boolean onPreDraw() {
107-
editText.getViewTreeObserver().removeOnPreDrawListener(this);
108-
editText.setTextIsSelectable(true);
109-
return true;
110-
}
111-
});
112101
return editText;
113102
}
114103

0 commit comments

Comments
 (0)