Skip to content

Commit c19bc79

Browse files
sherginfacebook-github-bot
authored andcommitted
[RCTShadowView isHidden] was removed
Summary: It's unused. Use `display` prop instead to control visiblity of the view. Reviewed By: fkgozali Differential Revision: D6888104 fbshipit-source-id: dd37a365033ec36bdfcfa305ec6a965a10dec2cd
1 parent 9dfa2e7 commit c19bc79

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

React/Modules/RCTUIManager.m

-7
Original file line numberDiff line numberDiff line change
@@ -496,7 +496,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
496496
UIUserInterfaceLayoutDirection layoutDirection;
497497
BOOL isNew;
498498
BOOL parentIsNew;
499-
BOOL isHidden;
500499
} RCTFrameData;
501500

502501
// Construct arrays then hand off to main thread
@@ -513,7 +512,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
513512
shadowView.layoutDirection,
514513
shadowView.isNewView,
515514
shadowView.superview.isNewView,
516-
shadowView.isHidden,
517515
};
518516
}
519517
}
@@ -570,7 +568,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
570568
UIView *view = viewRegistry[reactTag];
571569
CGRect frame = frameData.frame;
572570

573-
BOOL isHidden = frameData.isHidden;
574571
UIUserInterfaceLayoutDirection layoutDirection = frameData.layoutDirection;
575572
BOOL isNew = frameData.isNew;
576573
RCTLayoutAnimation *updatingLayoutAnimation = isNew ? nil : layoutAnimationGroup.updatingLayoutAnimation;
@@ -588,10 +585,6 @@ - (RCTViewManagerUIBlock)uiBlockWithLayoutUpdateForRootView:(RCTRootShadowView *
588585
}
589586
};
590587

591-
if (view.isHidden != isHidden) {
592-
view.hidden = isHidden;
593-
}
594-
595588
if (view.reactLayoutDirection != layoutDirection) {
596589
view.reactLayoutDirection = layoutDirection;
597590
}

React/Views/RCTShadowView.h

-6
Original file line numberDiff line numberDiff line change
@@ -70,12 +70,6 @@ typedef void (^RCTApplierBlock)(NSDictionary<NSNumber *, UIView *> *viewRegistry
7070
*/
7171
@property (nonatomic, assign, getter=isNewView) BOOL newView;
7272

73-
/**
74-
* isHidden - RCTUIManager uses this to determine whether or not the UIView should be hidden. Useful if the
75-
* ShadowView determines that its UIView will be clipped and wants to hide it.
76-
*/
77-
@property (nonatomic, assign, getter=isHidden) BOOL hidden;
78-
7973
/**
8074
* Computed layout direction of the view.
8175
*/

0 commit comments

Comments
 (0)