Skip to content

Commit c8e98bb

Browse files
dryganetsfacebook-github-bot
authored andcommitted
CI for Android fixed
Summary: Fix for android github CI. Github CI doesn't work without this change. CI passes. [INTERNAL] Android CI fix. Closes #17551 Differential Revision: D6707477 Pulled By: hramos fbshipit-source-id: f98515234da3b90ee3233523bcd7cc67ed82c1b4
1 parent e16d673 commit c8e98bb

File tree

3 files changed

+8
-7
lines changed
  • ReactAndroid/src/main/third-party/java/robolectric3/robolectric
  • ReactCommon

3 files changed

+8
-7
lines changed

ReactAndroid/src/main/third-party/java/robolectric3/robolectric/BUCK

+4-4
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ prebuilt_jar(
115115
export_file(
116116
name = "robolectric-android-all-binary-jar",
117117
src = ":robolectric-android-all-binary-remote-jar",
118-
out = "android-all-4.1.2_r1-robolectric-0.jar", # name defines filename used by robolectric in runtime
118+
out = "../android-all-4.1.2_r1-robolectric-0.jar", # name defines filename used by robolectric in runtime
119119
)
120120

121121
remote_file(
@@ -133,7 +133,7 @@ prebuilt_jar(
133133
export_file(
134134
name = "json-jar",
135135
src = ":json-remote-jar",
136-
out = "json-20080701.jar", # name defines filename used by robolectric in runtime
136+
out = "../json-20080701.jar", # name defines filename used by robolectric in runtime
137137
)
138138

139139
remote_file(
@@ -151,7 +151,7 @@ prebuilt_jar(
151151
export_file(
152152
name = "tagsoup-jar",
153153
src = ":tagsoup-remote-jar",
154-
out = "tagsoup-1.2.jar", # name defines filename used by robolectric in runtime
154+
out = "../tagsoup-1.2.jar", # name defines filename used by robolectric in runtime
155155
)
156156

157157
remote_file(
@@ -169,7 +169,7 @@ prebuilt_jar(
169169
export_file(
170170
name = "robolectric-shadows-binary-jar",
171171
src = ":robolectric-shadows-binary-remote-jar",
172-
out = "shadows-core-3.0-16.jar", # name defines filename used by robolectric in runtime
172+
out = "../shadows-core-3.0-16.jar", # name defines filename used by robolectric in runtime
173173
)
174174

175175
remote_file(

ReactCommon/DEFS

+1-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@
22

33
# Building is not supported in OSS right now
44
def rn_xplat_cxx_library(name, **kwargs):
5-
cxx_library(name = name)
6-
5+
cxx_library(name, **kwargs)
76
# Helper for referring to an Android RN target
87
def react_native_target(path):
98
return '//ReactAndroid/src/main/' + path

ReactCommon/yoga/BUCK

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
1-
fb_xplat_cxx_library(
1+
include_defs("//ReactCommon/DEFS")
2+
3+
rn_xplat_cxx_library(
24
name = "yoga",
35
srcs = glob(["yoga/*.cpp"]),
46
header_namespace = "",

0 commit comments

Comments
 (0)