Uninstalling native FabricUIManager when reloading RN screen

mdvacca · facebook-github-bot · commit ca3a6e8f1305 · 2018-10-12T18:41:51.000-07:00
Summary: This diff makes sure the native side of the UILayer of RN is deallocated when the a RN screen is reloaded.

Reviewed By: shergin

Differential Revision: D10343030

fbshipit-source-id: 7add841b8875d28fe527f20b96f799733769b11a
diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricBinding.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricBinding.java
@@ -11,7 +11,8 @@
 public interface FabricBinding {
 
   // TODO: T31905686 change types of UIManager and EventBeatManager when moving to OSS
-  void installFabric(
+  void register(
       JavaScriptContextHolder jsContext, FabricBinder fabricBinder, Object eventBeatManager);
 
+  void unregister();
 }

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,8 @@`
`11`	`11`	`public interface FabricBinding {`
`12`	`12`
`13`	`13`	`// TODO: T31905686 change types of UIManager and EventBeatManager when moving to OSS`
`14`		`- void installFabric(`
	`14`	`+ void register(`
`15`	`15`	`JavaScriptContextHolder jsContext, FabricBinder fabricBinder, Object eventBeatManager);`
`16`	`16`
	`17`	`+ void unregister();`
`17`	`18`	`}`