Skip to content

Commit cc2a73a

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Revert initialization of event emits during initial rendering in Fabric
Summary: Original commit changeset: 0b56b7495db6 Original Phabricator Diff: D53108114 bypass-github-export-checks changelog: [internal] internal Reviewed By: philIip Differential Revision: D53746331 fbshipit-source-id: 95daf5660845eb9a5dd84da85833727aed4e65e3
1 parent 3b2c4a1 commit cc2a73a

File tree

2 files changed

+0
-6
lines changed

2 files changed

+0
-6
lines changed

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributes.java

-1
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,6 @@ public float getEffectiveMaxFontSizeMultiplier() {
177177
: DEFAULT_MAX_FONT_SIZE_MULTIPLIER;
178178
}
179179

180-
@Override
181180
public String toString() {
182181
return ("TextAttributes {"
183182
+ "\n getAllowFontScaling(): "

packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp

-5
Original file line numberDiff line numberDiff line change
@@ -810,11 +810,6 @@ void FabricMountingManager::preallocateShadowView(
810810

811811
// Do not hold a reference to javaEventEmitter from the C++ side.
812812
jni::local_ref<EventEmitterWrapper::JavaPart> javaEventEmitter = nullptr;
813-
SharedEventEmitter eventEmitter = shadowView.eventEmitter;
814-
if (eventEmitter != nullptr) {
815-
javaEventEmitter =
816-
EventEmitterWrapper::newObjectCxxArgs(shadowView.eventEmitter);
817-
}
818813

819814
jni::local_ref<jobject> props = getProps({}, shadowView);
820815

0 commit comments

Comments
 (0)