Skip to content

Commit d7a9ca2

Browse files
gengjiawenfacebook-github-bot
authored andcommittedJan 20, 2018
Remove redundant config in AndroidManifest.xml
Summary: * remove redundant version code, name, miniSdk, targetSdk, they now are configed in build.gradle * allowbackup = true is not a secure config <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> Clean up redundant config and remove security risk config. test android template still works. none <!-- Help reviewers and the release process by writing your own release notes **INTERNAL and MINOR tagged notes will not be included in the next version's final release notes.** CATEGORY [----------] TYPE [ CLI ] [-------------] LOCATION [ DOCS ] [ BREAKING ] [-------------] [ GENERAL ] [ BUGFIX ] [-{Component}-] [ INTERNAL ] [ ENHANCEMENT ] [ {File} ] [ IOS ] [ FEATURE ] [ {Directory} ] |-----------| [ ANDROID ] [ MINOR ] [ {Framework} ] - | {Message} | [----------] [-------------] [-------------] |-----------| [CATEGORY] [TYPE] [LOCATION] - MESSAGE EXAMPLES: [IOS] [BREAKING] [FlatList] - Change a thing that breaks other things [ANDROID] [BUGFIX] [TextInput] - Did a thing to TextInput [CLI] [FEATURE] [local-cli/info/info.js] - CLI easier to do things with [DOCS] [BUGFIX] [GettingStarted.md] - Accidentally a thing/word [GENERAL] [ENHANCEMENT] [Yoga] - Added new yoga thing/position [INTERNAL] [FEATURE] [./scripts] - Added thing to script that nobody will see --> Closes #17596 Differential Revision: D6768292 Pulled By: hramos fbshipit-source-id: 9f32f17aebb9c1857d8b64d6687efe7c22e7bc79
1 parent 431670f commit d7a9ca2

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed
 

‎local-cli/templates/HelloWorld/android/app/src/main/AndroidManifest.xml

+2-8
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,14 @@
11
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
2-
package="com.helloworld"
3-
android:versionCode="1"
4-
android:versionName="1.0">
2+
package="com.helloworld">
53

64
<uses-permission android:name="android.permission.INTERNET" />
75
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
86

9-
<uses-sdk
10-
android:minSdkVersion="16"
11-
android:targetSdkVersion="22" />
12-
137
<application
148
android:name=".MainApplication"
15-
android:allowBackup="true"
169
android:label="@string/app_name"
1710
android:icon="@mipmap/ic_launcher"
11+
android:allowBackup="false"
1812
android:theme="@style/AppTheme">
1913
<activity
2014
android:name=".MainActivity"

0 commit comments

Comments
 (0)
Please sign in to comment.