Skip to content

Commit d8bb990

Browse files
Sasha Nikiforovfacebook-github-bot
Sasha Nikiforov
authored andcommitted
Update ReactAndroid build script to support gradle 2.3.0
Summary: We updated to Gradle 2.3.0 and our app's build failed. Our app doesn't provide "repositoryUrl" which is intended to be an optional gradle property. However, Gradle 2.3.0 blows up on findProperty('repositoryUrl') when "repositoryUrl" isn't provided: ```` * What went wrong: A problem occurred configuring project ':ContextMenuAndroid'. > Could not resolve all dependencies for configuration ':ContextMenuAndroid:_debugPublish'. > A problem occurred configuring project ':ReactAndroid'. > Could not get unknown property 'repositoryUrl' for project ':ReactAndroid' of type org.gradle.api.Project. ```` To fix this, we now use "project.hasProperty('repositoryUrl')" to safely detect the presence of the optional "repositoryUrl" property. Since I cannot check it with your build environment, I've created a small demo to show that "project.hasProperty" properly detects the presence of the gradle property "repositoryUrl". I edited "getRepositoryUrl" to throw an exception if "repositoryUrl" is set: ```` def getRepositoryUrl() { if (project.hasProperty('repositoryUrl')) throw new GradleException(property('repositoryUrl')) return project.hasProperty('repositoryUrl') ? property('repositoryUrl') : 'https://oss.sonatype.org/service/local/staging/deploy/maven2/' } ```` Then I ran gradle with "repositoryUrl" set like this (passing the property): ```` ./gradlew -PrepositoryUrl=blah assembleDebug ```` As expected, it detected that "repositoryUrl" was set and threw an exception: ```` * What went wrong: A problem occurred configuring project ':ContextMenuAndroid'. > Could not resolve all dependencies for configuration ':ContextMenuAndroid:_debugPublish'. > A problem occurred configuring project ':ReactAndroid'. > blah ```` The same issue has been reported before - #14811, #14810 Minor changes in the Android build script Closes #18075 Differential Revision: D7077788 Pulled By: hramos fbshipit-source-id: ecfbab29d0632e7eecb3c6a247df39bc7616653e
1 parent 1b63da7 commit d8bb990

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Diff for: ReactAndroid/release.gradle

+3-3
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ def isReleaseBuild() {
1212
}
1313

1414
def getRepositoryUrl() {
15-
return hasProperty('repositoryUrl') ? property('repositoryUrl') : 'https://oss.sonatype.org/service/local/staging/deploy/maven2/'
15+
return project.hasProperty('repositoryUrl') ? property('repositoryUrl') : 'https://oss.sonatype.org/service/local/staging/deploy/maven2/'
1616
}
1717

1818
def getRepositoryUsername() {
19-
return hasProperty('repositoryUsername') ? property('repositoryUsername') : ''
19+
return project.hasProperty('repositoryUsername') ? property('repositoryUsername') : ''
2020
}
2121

2222
def getRepositoryPassword() {
23-
return hasProperty('repositoryPassword') ? property('repositoryPassword') : ''
23+
return project.hasProperty('repositoryPassword') ? property('repositoryPassword') : ''
2424
}
2525

2626
def configureReactNativePom(def pom) {

0 commit comments

Comments
 (0)