RCTSurface: Use async dispatch to register root shadow view

shergin · facebook-github-bot · commit da17b237e15e · 2017-12-03T20:16:35.000-08:00
Summary: We don't really need sync dispatch here. We only need sequential execution of our UIManager blocks.

Reviewed By: rsnara

Differential Revision: D6367069

fbshipit-source-id: cc675aafd6c762506048bcf65c24e54080b013a5
diff --git a/React/Base/Surface/RCTSurface.mm b/React/Base/Surface/RCTSurface.mm
@@ -311,7 +311,7 @@ - (void)_registerRootViewTag
   }
 
   RCTUIManager *uiManager = batchedBridge.uiManager;
-  RCTUnsafeExecuteOnUIManagerQueueSync(^{
+  RCTExecuteOnUIManagerQueue(^{
     [uiManager registerRootViewTag:self->_rootViewTag];
 
     RCTSurfaceRootShadowView *rootShadowView =

Original file line number	Diff line number	Diff line change
`@@ -311,7 +311,7 @@ - (void)_registerRootViewTag`
`311`	`311`	`}`
`312`	`312`
`313`	`313`	`RCTUIManager *uiManager = batchedBridge.uiManager;`
`314`		`- RCTUnsafeExecuteOnUIManagerQueueSync(^{`
	`314`	`+ RCTExecuteOnUIManagerQueue(^{`
`315`	`315`	`[uiManager registerRootViewTag:self->_rootViewTag];`
`316`	`316`
`317`	`317`	`RCTSurfaceRootShadowView *rootShadowView =`