RNTester: Relax Bridge Release Check

yungsters · facebook-github-bot · commit e3c6f38773d0 · 2018-01-05T15:05:31.000-08:00
Reviewed By: mmmulani

Differential Revision: D6665596

fbshipit-source-id: 2c59ea8add039d2bfc6b76701d16e82088fa8aad
diff --git a/Libraries/RCTTest/RCTTestRunner.m b/Libraries/RCTTest/RCTTestRunner.m
@@ -186,13 +186,12 @@ - (void)runTest:(SEL)test module:(NSString *)moduleName
     [bridge invalidate];
   }
 
-  // Wait for bridge to disappear before continuing to the next test
+  // Give the bridge a chance to disappear before continuing to the next test.
   NSDate *invalidateTimeout = [NSDate dateWithTimeIntervalSinceNow:30];
   while (invalidateTimeout.timeIntervalSinceNow > 0 && batchedBridge != nil) {
     [[NSRunLoop mainRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];
     [[NSRunLoop mainRunLoop] runMode:NSRunLoopCommonModes beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];
   }
-  RCTAssert(batchedBridge == nil, @"Bridge should be deallocated after the test");
 }
 
 @end

Original file line number	Diff line number	Diff line change
`@@ -186,13 +186,12 @@ - (void)runTest:(SEL)test module:(NSString *)moduleName`
`186`	`186`	`[bridge invalidate];`
`187`	`187`	`}`
`188`	`188`
`189`		`- // Wait for bridge to disappear before continuing to the next test`
	`189`	`+ // Give the bridge a chance to disappear before continuing to the next test.`
`190`	`190`	`NSDate *invalidateTimeout = [NSDate dateWithTimeIntervalSinceNow:30];`
`191`	`191`	`while (invalidateTimeout.timeIntervalSinceNow > 0 && batchedBridge != nil) {`
`192`	`192`	`[[NSRunLoop mainRunLoop] runMode:NSDefaultRunLoopMode beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];`
`193`	`193`	`[[NSRunLoop mainRunLoop] runMode:NSRunLoopCommonModes beforeDate:[NSDate dateWithTimeIntervalSinceNow:0.1]];`
`194`	`194`	`}`
`195`		`- RCTAssert(batchedBridge == nil, @"Bridge should be deallocated after the test");`
`196`	`195`	`}`
`197`	`196`
`198`	`197`	`@end`