Skip to content

Commit e903d80

Browse files
dratwasfacebook-github-bot
authored andcommitted
Move eslint/prettier config to packages/eslint-config-react-native (#23688)
Summary: Basing on discussion from this issue - react-native-community/discussions-and-proposals#65 we moved ESLint/Prettier config to its own package inside packages directory. At this moment we had to left all `eslint` dependencies in root `package.json` since `eslint-config-react-native` is not published yet. [General] [Changed] - Move eslint/prettier config to packages/eslint-config-react-native Pull Request resolved: #23688 Differential Revision: D14277068 Pulled By: cpojer fbshipit-source-id: ef2d0b33210418318cc8324f15fedd84df0ef64d
1 parent eecf651 commit e903d80

File tree

4 files changed

+1441
-255
lines changed

4 files changed

+1441
-255
lines changed

Diff for: .eslintrc

+2-255
Original file line numberDiff line numberDiff line change
@@ -1,263 +1,10 @@
11
{
22
"root": true,
33

4-
"parser": "babel-eslint",
5-
6-
"env": {
7-
"es6": true,
8-
},
9-
10-
"plugins": [
11-
"eslint-comments",
12-
"flowtype",
13-
"prettier",
14-
"react",
15-
"react-hooks",
16-
"react-native",
17-
"jest",
4+
"extends": [
5+
"./packages/eslint-config-react-native/index.js"
186
],
197

20-
// Map from global var to bool specifying if it can be redefined
21-
"globals": {
22-
"__DEV__": true,
23-
"__dirname": false,
24-
"__fbBatchedBridgeConfig": false,
25-
"alert": false,
26-
"cancelAnimationFrame": false,
27-
"cancelIdleCallback": false,
28-
"clearImmediate": true,
29-
"clearInterval": false,
30-
"clearTimeout": false,
31-
"console": false,
32-
"document": false,
33-
"escape": false,
34-
"Event": false,
35-
"EventTarget": false,
36-
"exports": false,
37-
"fetch": false,
38-
"FormData": false,
39-
"global": false,
40-
"Map": true,
41-
"module": false,
42-
"navigator": false,
43-
"process": false,
44-
"Promise": true,
45-
"requestAnimationFrame": true,
46-
"requestIdleCallback": true,
47-
"require": false,
48-
"Set": true,
49-
"setImmediate": true,
50-
"setInterval": false,
51-
"setTimeout": false,
52-
"window": false,
53-
"XMLHttpRequest": false,
54-
},
55-
56-
"rules": {
57-
// General
58-
"comma-dangle": [1, "always-multiline"], // allow or disallow trailing commas
59-
"no-cond-assign": 1, // disallow assignment in conditional expressions
60-
"no-console": 0, // disallow use of console (off by default in the node environment)
61-
"no-const-assign": 2, // disallow assignment to const-declared variables
62-
"no-constant-condition": 0, // disallow use of constant expressions in conditions
63-
"no-control-regex": 1, // disallow control characters in regular expressions
64-
"no-debugger": 1, // disallow use of debugger
65-
"no-dupe-class-members": 2, // Disallow duplicate name in class members
66-
"no-dupe-keys": 2, // disallow duplicate keys when creating object literals
67-
"no-empty": 0, // disallow empty statements
68-
"no-ex-assign": 1, // disallow assigning to the exception in a catch block
69-
"no-extra-boolean-cast": 1, // disallow double-negation boolean casts in a boolean context
70-
"no-extra-parens": 0, // disallow unnecessary parentheses (off by default)
71-
"no-extra-semi": 1, // disallow unnecessary semicolons
72-
"no-func-assign": 1, // disallow overwriting functions written as function declarations
73-
"no-inner-declarations": 0, // disallow function or variable declarations in nested blocks
74-
"no-invalid-regexp": 1, // disallow invalid regular expression strings in the RegExp constructor
75-
"no-negated-in-lhs": 1, // disallow negation of the left operand of an in expression
76-
"no-obj-calls": 1, // disallow the use of object properties of the global object (Math and JSON) as functions
77-
"no-regex-spaces": 1, // disallow multiple spaces in a regular expression literal
78-
"no-reserved-keys": 0, // disallow reserved words being used as object literal keys (off by default)
79-
"no-sparse-arrays": 1, // disallow sparse arrays
80-
"no-unreachable": 2, // disallow unreachable statements after a return, throw, continue, or break statement
81-
"use-isnan": 1, // disallow comparisons with the value NaN
82-
"valid-jsdoc": 0, // Ensure JSDoc comments are valid (off by default)
83-
"valid-typeof": 1, // Ensure that the results of typeof are compared against a valid string
84-
85-
// Best Practices
86-
// These are rules designed to prevent you from making mistakes. They either prescribe a better way of doing something or help you avoid footguns.
87-
88-
"block-scoped-var": 0, // treat var statements as if they were block scoped (off by default)
89-
"complexity": 0, // specify the maximum cyclomatic complexity allowed in a program (off by default)
90-
"consistent-return": 0, // require return statements to either always or never specify values
91-
"curly": 1, // specify curly brace conventions for all control statements
92-
"default-case": 0, // require default case in switch statements (off by default)
93-
"dot-notation": 1, // encourages use of dot notation whenever possible
94-
"eqeqeq": [1, "allow-null"], // require the use of === and !==
95-
"guard-for-in": 0, // make sure for-in loops have an if statement (off by default)
96-
"no-alert": 1, // disallow the use of alert, confirm, and prompt
97-
"no-caller": 1, // disallow use of arguments.caller or arguments.callee
98-
"no-div-regex": 1, // disallow division operators explicitly at beginning of regular expression (off by default)
99-
"no-else-return": 0, // disallow else after a return in an if (off by default)
100-
"no-eq-null": 0, // disallow comparisons to null without a type-checking operator (off by default)
101-
"no-eval": 2, // disallow use of eval()
102-
"no-extend-native": 1, // disallow adding to native types
103-
"no-extra-bind": 1, // disallow unnecessary function binding
104-
"no-fallthrough": 1, // disallow fallthrough of case statements
105-
"no-floating-decimal": 1, // disallow the use of leading or trailing decimal points in numeric literals (off by default)
106-
"no-implied-eval": 1, // disallow use of eval()-like methods
107-
"no-labels": 1, // disallow use of labeled statements
108-
"no-iterator": 1, // disallow usage of __iterator__ property
109-
"no-lone-blocks": 1, // disallow unnecessary nested blocks
110-
"no-loop-func": 0, // disallow creation of functions within loops
111-
"no-multi-str": 0, // disallow use of multiline strings
112-
"no-native-reassign": 0, // disallow reassignments of native objects
113-
"no-new": 1, // disallow use of new operator when not part of the assignment or comparison
114-
"no-new-func": 2, // disallow use of new operator for Function object
115-
"no-new-wrappers": 1, // disallows creating new instances of String,Number, and Boolean
116-
"no-octal": 1, // disallow use of octal literals
117-
"no-octal-escape": 1, // disallow use of octal escape sequences in string literals, such as var foo = "Copyright \251";
118-
"no-proto": 1, // disallow usage of __proto__ property
119-
"no-redeclare": 0, // disallow declaring the same variable more then once
120-
"no-return-assign": 1, // disallow use of assignment in return statement
121-
"no-script-url": 1, // disallow use of javascript: urls.
122-
"no-self-compare": 1, // disallow comparisons where both sides are exactly the same (off by default)
123-
"no-sequences": 1, // disallow use of comma operator
124-
"no-unused-expressions": 0, // disallow usage of expressions in statement position
125-
"no-void": 1, // disallow use of void operator (off by default)
126-
"no-warning-comments": 0, // disallow usage of configurable warning terms in comments": 1, // e.g. TODO or FIXME (off by default)
127-
"no-with": 1, // disallow use of the with statement
128-
"radix": 1, // require use of the second argument for parseInt() (off by default)
129-
"semi-spacing": 1, // require a space after a semi-colon
130-
"vars-on-top": 0, // requires to declare all vars on top of their containing scope (off by default)
131-
"wrap-iife": 0, // require immediate function invocation to be wrapped in parentheses (off by default)
132-
"yoda": 1, // require or disallow Yoda conditions
133-
134-
// Variables
135-
// These rules have to do with variable declarations.
136-
137-
"no-catch-shadow": 1, // disallow the catch clause parameter name being the same as a variable in the outer scope (off by default in the node environment)
138-
"no-delete-var": 1, // disallow deletion of variables
139-
"no-label-var": 1, // disallow labels that share a name with a variable
140-
"no-shadow": 1, // disallow declaration of variables already declared in the outer scope
141-
"no-shadow-restricted-names": 1, // disallow shadowing of names such as arguments
142-
"no-undef": 2, // disallow use of undeclared variables unless mentioned in a /*global */ block
143-
"no-undefined": 0, // disallow use of undefined variable (off by default)
144-
"no-undef-init": 1, // disallow use of undefined when initializing variables
145-
"no-unused-vars": [1, {"vars": "all", "args": "none", ignoreRestSiblings: true}], // disallow declaration of variables that are not used in the code
146-
"no-use-before-define": 0, // disallow use of variables before they are defined
147-
148-
// Node.js
149-
// These rules are specific to JavaScript running on Node.js.
150-
151-
"handle-callback-err": 1, // enforces error handling in callbacks (off by default) (on by default in the node environment)
152-
"no-mixed-requires": 1, // disallow mixing regular variable and require declarations (off by default) (on by default in the node environment)
153-
"no-new-require": 1, // disallow use of new operator with the require function (off by default) (on by default in the node environment)
154-
"no-path-concat": 1, // disallow string concatenation with __dirname and __filename (off by default) (on by default in the node environment)
155-
"no-process-exit": 0, // disallow process.exit() (on by default in the node environment)
156-
"no-restricted-modules": 1, // restrict usage of specified node modules (off by default)
157-
"no-sync": 0, // disallow use of synchronous methods (off by default)
158-
159-
// ESLint Comments Plugin
160-
// The following rules are made available via `eslint-plugin-eslint-comments`
161-
"eslint-comments/no-aggregating-enable": 1, // disallows eslint-enable comments for multiple eslint-disable comments
162-
"eslint-comments/no-unlimited-disable": 1, // disallows eslint-disable comments without rule names
163-
"eslint-comments/no-unused-disable": 1, // disallow disables that don't cover any errors
164-
"eslint-comments/no-unused-enable": 1, // // disallow enables that don't enable anything or enable rules that weren't disabled
165-
166-
// Flow Plugin
167-
// The following rules are made available via `eslint-plugin-flowtype`
168-
"flowtype/define-flow-type": 1,
169-
"flowtype/use-flow-type": 1,
170-
171-
// Prettier Plugin
172-
// https://github.com/prettier/eslint-plugin-prettier
173-
"prettier/prettier": [2, "fb", "@format"],
174-
175-
// Stylistic Issues
176-
// These rules are purely matters of style and are quite subjective.
177-
178-
"key-spacing": 0,
179-
"keyword-spacing": 1, // enforce spacing before and after keywords
180-
"jsx-quotes": [1, "prefer-double"], // enforces the usage of double quotes for all JSX attribute values which doesn’t contain a double quote
181-
"comma-spacing": 0,
182-
"no-multi-spaces": 0,
183-
"brace-style": 0, // enforce one true brace style (off by default)
184-
"camelcase": 0, // require camel case names
185-
"consistent-this": 1, // enforces consistent naming when capturing the current execution context (off by default)
186-
"eol-last": 1, // enforce newline at the end of file, with no multiple empty lines
187-
"func-names": 0, // require function expressions to have a name (off by default)
188-
"func-style": 0, // enforces use of function declarations or expressions (off by default)
189-
"new-cap": 0, // require a capital letter for constructors
190-
"new-parens": 1, // disallow the omission of parentheses when invoking a constructor with no arguments
191-
"no-nested-ternary": 0, // disallow nested ternary expressions (off by default)
192-
"no-array-constructor": 1, // disallow use of the Array constructor
193-
"no-empty-character-class": 1, // disallow the use of empty character classes in regular expressions
194-
"no-lonely-if": 0, // disallow if as the only statement in an else block (off by default)
195-
"no-new-object": 1, // disallow use of the Object constructor
196-
"no-spaced-func": 1, // disallow space between function identifier and application
197-
"no-ternary": 0, // disallow the use of ternary operators (off by default)
198-
"no-trailing-spaces": 1, // disallow trailing whitespace at the end of lines
199-
"no-underscore-dangle": 0, // disallow dangling underscores in identifiers
200-
"no-mixed-spaces-and-tabs": 1, // disallow mixed spaces and tabs for indentation
201-
"quotes": [1, "single", "avoid-escape"], // specify whether double or single quotes should be used
202-
"quote-props": 0, // require quotes around object literal property names (off by default)
203-
"semi": 1, // require or disallow use of semicolons instead of ASI
204-
"sort-vars": 0, // sort variables within the same declaration block (off by default)
205-
"space-in-brackets": 0, // require or disallow spaces inside brackets (off by default)
206-
"space-in-parens": 0, // require or disallow spaces inside parentheses (off by default)
207-
"space-infix-ops": 1, // require spaces around operators
208-
"space-unary-ops": [1, { "words": true, "nonwords": false }], // require or disallow spaces before/after unary operators (words on by default, nonwords off by default)
209-
"max-nested-callbacks": 0, // specify the maximum depth callbacks can be nested (off by default)
210-
"one-var": 0, // allow just one var statement per function (off by default)
211-
"wrap-regex": 0, // require regex literals to be wrapped in parentheses (off by default)
212-
213-
// Legacy
214-
// The following rules are included for compatibility with JSHint and JSLint. While the names of the rules may not match up with the JSHint/JSLint counterpart, the functionality is the same.
215-
216-
"max-depth": 0, // specify the maximum depth that blocks can be nested (off by default)
217-
"max-len": 0, // specify the maximum length of a line in your program (off by default)
218-
"max-params": 0, // limits the number of parameters that can be used in the function declaration. (off by default)
219-
"max-statements": 0, // specify the maximum number of statement allowed in a function (off by default)
220-
"no-bitwise": 1, // disallow use of bitwise operators (off by default)
221-
"no-plusplus": 0, // disallow use of unary operators, ++ and -- (off by default)
222-
223-
// React Plugin
224-
// The following rules are made available via `eslint-plugin-react`.
225-
226-
"react/display-name": 0,
227-
"react/jsx-boolean-value": 0,
228-
"react/jsx-no-comment-textnodes": 1,
229-
"react/jsx-no-duplicate-props": 2,
230-
"react/jsx-no-undef": 2,
231-
"react/jsx-sort-props": 0,
232-
"react/jsx-uses-react": 1,
233-
"react/jsx-uses-vars": 1,
234-
"react/no-did-mount-set-state": 1,
235-
"react/no-did-update-set-state": 1,
236-
"react/no-multi-comp": 0,
237-
"react/no-string-refs": 1,
238-
"react/no-unknown-property": 0,
239-
"react/prop-types": 0,
240-
"react/react-in-jsx-scope": 1,
241-
"react/self-closing-comp": 1,
242-
"react/wrap-multilines": 0,
243-
244-
// React-Hooks Plugin
245-
// The following rules are made available via `eslint-plugin-react-hooks`
246-
"react-hooks/rules-of-hooks": "error",
247-
248-
// React-Native Plugin
249-
// The following rules are made available via `eslint-plugin-react-native`
250-
251-
"react-native/no-inline-styles": 1,
252-
253-
// Jest Plugin
254-
// The following rules are made available via `eslint-plugin-jest`.
255-
"jest/no-disabled-tests": 1,
256-
"jest/no-focused-tests": 1,
257-
"jest/no-identical-title": 1,
258-
"jest/valid-expect": 1,
259-
},
260-
2618
"overrides": [
2629
{
26310
"files": [

0 commit comments

Comments
 (0)