Skip to content

Commit eb0d647

Browse files
Caleb Meredithfacebook-github-bot
Caleb Meredith
authored andcommitted
Flow 0.59 xplat/js deploy
Reviewed By: avikchaudhuri Differential Revision: D6300238 fbshipit-source-id: a6839fa2a9bbc50c3832a3f5b1cac2a6d2bd96b7
1 parent 7fb3a92 commit eb0d647

File tree

9 files changed

+72
-9
lines changed

9 files changed

+72
-9
lines changed

.flowconfig

+3-3
Original file line numberDiff line numberDiff line change
@@ -46,12 +46,12 @@ suppress_type=$FlowFixMeProps
4646
suppress_type=$FlowFixMeState
4747
suppress_type=$FixMe
4848

49-
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-8]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)
50-
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-8]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)?:? #[0-9]+
49+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-9]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)
50+
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-9]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*[react_native_oss|react_native_fb][a-z,_]*\\)?)\\)?:? #[0-9]+
5151
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
5252
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
5353

5454
unsafe.enable_getters_and_setters=true
5555

5656
[version]
57-
^0.58.0
57+
^0.59.0

Libraries/Animated/src/Easing.js

+41
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,21 @@ class Easing {
6262
/**
6363
* A stepping function, returns 1 for any positive value of `n`.
6464
*/
65+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
66+
* caught by Flow 0.59 which was not caught before. Most likely, this error
67+
* is because an exported function parameter is missing an annotation.
68+
* Without an annotation, these parameters are uncovered by Flow. */
6569
static step0(n) {
6670
return n > 0 ? 1 : 0;
6771
}
6872

6973
/**
7074
* A stepping function, returns 1 if `n` is greater than or equal to 1.
7175
*/
76+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
77+
* caught by Flow 0.59 which was not caught before. Most likely, this error
78+
* is because an exported function parameter is missing an annotation.
79+
* Without an annotation, these parameters are uncovered by Flow. */
7280
static step1(n) {
7381
return n >= 1 ? 1 : 0;
7482
}
@@ -79,6 +87,10 @@ class Easing {
7987
*
8088
* http://cubic-bezier.com/#0,0,1,1
8189
*/
90+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
91+
* caught by Flow 0.59 which was not caught before. Most likely, this error
92+
* is because an exported function parameter is missing an annotation.
93+
* Without an annotation, these parameters are uncovered by Flow. */
8294
static linear(t) {
8395
return t;
8496
}
@@ -102,6 +114,10 @@ class Easing {
102114
*
103115
* http://easings.net/#easeInQuad
104116
*/
117+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
118+
* caught by Flow 0.59 which was not caught before. Most likely, this error
119+
* is because an exported function parameter is missing an annotation.
120+
* Without an annotation, these parameters are uncovered by Flow. */
105121
static quad(t) {
106122
return t * t;
107123
}
@@ -112,6 +128,10 @@ class Easing {
112128
*
113129
* http://easings.net/#easeInCubic
114130
*/
131+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
132+
* caught by Flow 0.59 which was not caught before. Most likely, this error
133+
* is because an exported function parameter is missing an annotation.
134+
* Without an annotation, these parameters are uncovered by Flow. */
115135
static cubic(t) {
116136
return t * t * t;
117137
}
@@ -122,7 +142,16 @@ class Easing {
122142
* n = 4: http://easings.net/#easeInQuart
123143
* n = 5: http://easings.net/#easeInQuint
124144
*/
145+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
146+
* caught by Flow 0.59 which was not caught before. Most likely, this error
147+
* is because an exported function parameter is missing an annotation.
148+
* Without an annotation, these parameters are uncovered by Flow. */
125149
static poly(n) {
150+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an
151+
* error caught by Flow 0.59 which was not caught before. Most likely, this
152+
* error is because an exported function parameter is missing an
153+
* annotation. Without an annotation, these parameters are uncovered by
154+
* Flow. */
126155
return (t) => Math.pow(t, n);
127156
}
128157

@@ -131,6 +160,10 @@ class Easing {
131160
*
132161
* http://easings.net/#easeInSine
133162
*/
163+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
164+
* caught by Flow 0.59 which was not caught before. Most likely, this error
165+
* is because an exported function parameter is missing an annotation.
166+
* Without an annotation, these parameters are uncovered by Flow. */
134167
static sin(t) {
135168
return 1 - Math.cos(t * Math.PI / 2);
136169
}
@@ -140,6 +173,10 @@ class Easing {
140173
*
141174
* http://easings.net/#easeInCirc
142175
*/
176+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
177+
* caught by Flow 0.59 which was not caught before. Most likely, this error
178+
* is because an exported function parameter is missing an annotation.
179+
* Without an annotation, these parameters are uncovered by Flow. */
143180
static circle(t) {
144181
return 1 - Math.sqrt(1 - t * t);
145182
}
@@ -149,6 +186,10 @@ class Easing {
149186
*
150187
* http://easings.net/#easeInExpo
151188
*/
189+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
190+
* caught by Flow 0.59 which was not caught before. Most likely, this error
191+
* is because an exported function parameter is missing an annotation.
192+
* Without an annotation, these parameters are uncovered by Flow. */
152193
static exp(t) {
153194
return Math.pow(2, 10 * (t - 1));
154195
}

Libraries/CameraRoll/CameraRoll.js

+4
Original file line numberDiff line numberDiff line change
@@ -255,6 +255,10 @@ class CameraRoll {
255255
* }
256256
* ```
257257
*/
258+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
259+
* caught by Flow 0.59 which was not caught before. Most likely, this error
260+
* is because an exported function parameter is missing an annotation.
261+
* Without an annotation, these parameters are uncovered by Flow. */
258262
static getPhotos(params) {
259263
if (__DEV__) {
260264
checkPropTypes(

Libraries/Experimental/WindowedListView.js

+5
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,11 @@ class WindowedListView extends React.Component<Props, State> {
176176
maxNumToRender: 30,
177177
numToRenderAhead: 10,
178178
viewablePercentThreshold: 50,
179+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an
180+
* error caught by Flow 0.59 which was not caught before. Most likely, this
181+
* error is because an exported function parameter is missing an
182+
* annotation. Without an annotation, these parameters are uncovered by
183+
* Flow. */
179184
renderScrollComponent: (props) => <ScrollView {...props} />,
180185
disableIncrementalRendering: false,
181186
recomputeRowsBatchingPeriod: 10, // This should capture most events that happen within a frame

Libraries/Lists/ListView/__mocks__/ListViewMock.js

+5
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,11 @@ const StaticRenderer = require('StaticRenderer');
1919
class ListViewMock extends React.Component<$FlowFixMeProps> {
2020
static latestRef: ?ListViewMock;
2121
static defaultProps = {
22+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an
23+
* error caught by Flow 0.59 which was not caught before. Most likely, this
24+
* error is because an exported function parameter is missing an
25+
* annotation. Without an annotation, these parameters are uncovered by
26+
* Flow. */
2227
renderScrollComponent: props => <ScrollView {...props} />,
2328
};
2429
componentDidMount() {

Libraries/Share/Share.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,13 @@ class Share {
111111
/**
112112
* The content was successfully shared.
113113
*/
114-
static get sharedAction() { return 'sharedAction'; }
114+
static get sharedAction(): string { return 'sharedAction'; }
115115

116116
/**
117117
* The dialog has been dismissed.
118118
* @platform ios
119119
*/
120-
static get dismissedAction() { return 'dismissedAction'; }
120+
static get dismissedAction(): string { return 'dismissedAction'; }
121121

122122
}
123123

Libraries/StyleSheet/StyleSheetValidation.js

+8
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@ var invariant = require('fbjs/lib/invariant');
2424
const ReactPropTypesSecret = 'SECRET_DO_NOT_PASS_THIS_OR_YOU_WILL_BE_FIRED';
2525

2626
class StyleSheetValidation {
27+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
28+
* caught by Flow 0.59 which was not caught before. Most likely, this error
29+
* is because an exported function parameter is missing an annotation.
30+
* Without an annotation, these parameters are uncovered by Flow. */
2731
static validateStyleProp(prop, style, caller) {
2832
if (!__DEV__) {
2933
return;
@@ -59,6 +63,10 @@ class StyleSheetValidation {
5963
}
6064
}
6165

66+
/* $FlowFixMe(>=0.59.0 site=react_native_fb) This comment suppresses an error
67+
* caught by Flow 0.59 which was not caught before. Most likely, this error
68+
* is because an exported function parameter is missing an annotation.
69+
* Without an annotation, these parameters are uncovered by Flow. */
6270
static validateStyle(name, styles) {
6371
if (!__DEV__) {
6472
return;

local-cli/templates/HelloWorld/_flowconfig

+3-3
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,12 @@ suppress_type=$FlowFixMeProps
3737
suppress_type=$FlowFixMeState
3838
suppress_type=$FixMe
3939

40-
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-8]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
41-
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-8]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
40+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(5[0-9]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
41+
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(5[0-9]\\|[1-4][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
4242
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
4343
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
4444

4545
unsafe.enable_getters_and_setters=true
4646

4747
[version]
48-
^0.58.0
48+
^0.59.0

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@
208208
"eslint-plugin-flowtype": "^2.33.0",
209209
"eslint-plugin-prettier": "2.1.1",
210210
"eslint-plugin-react": "^7.2.1",
211-
"flow-bin": "^0.58.0",
211+
"flow-bin": "^0.59.0",
212212
"jest": "21.3.0-beta.8",
213213
"prettier": "1.7.0",
214214
"react": "16.0.0",

0 commit comments

Comments
 (0)