Skip to content

Commit f59140e

Browse files
gkmhubfacebook-github-bot
authored andcommitted
Use clang-5.0 -Oz
Reviewed By: mzlee Differential Revision: D6155682 fbshipit-source-id: 2f64e742f4dc44be171274c2ad0a41fb1e7079d7
1 parent a7b231a commit f59140e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

Diff for: ReactCommon/yoga/yoga/Yoga.cpp

+6
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,12 @@ static int YGDefaultLog(const YGConfigRef config,
133133
#endif
134134

135135
bool YGFloatIsUndefined(const float value) {
136+
// TODO(gkm): Ugh! Some Android builds (r13b & clang-3.8) fail
137+
// with the kludge below, so we must tailor it specifically for
138+
// NDK r15c which has clang-5.0. NDK r16 will make it all better.
139+
#if __ANDROID__ && __clang_major__ == 5 // TODO(gkm): remove for NDK >= 16
140+
using std::isnan;
141+
#endif
136142
return isnan(value);
137143
}
138144

0 commit comments

Comments
 (0)