Skip to content

Commit f83281e

Browse files
mdvaccafacebook-github-bot
authored andcommittedFeb 11, 2019
Disable OverlappingRendering for ReactTextView
Summary: This diff disables OverlappingRendering for ReactTextView to avoid the exception: ``` java.lang.IllegalStateException: Unable to create layer for com.facebook.react.views.text.ReactTextView ``` during fade animations OverlappingRendering enables an optimization during rendering of animations per component, disabling this might affect performance of animations inside TextView. We will add a ReactFlag to experiment on how this affect other surfaces. Reviewed By: blairvanderhoof Differential Revision: D14027631 fbshipit-source-id: c1a84e7488c44582f7b7c78965aeb7bd27f82368
1 parent cdd6151 commit f83281e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed
 

‎ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java

+5
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,11 @@ public void onFinishTemporaryDetach() {
211211
}
212212
}
213213

214+
@Override
215+
public boolean hasOverlappingRendering() {
216+
return false;
217+
}
218+
214219
/* package */ void setGravityHorizontal(int gravityHorizontal) {
215220
if (gravityHorizontal == 0) {
216221
gravityHorizontal = mDefaultGravityHorizontal;

0 commit comments

Comments
 (0)
Please sign in to comment.