Skip to content

Commit ff2658c

Browse files
passyfacebook-github-bot
authored andcommitted
Mark model fields final
Reviewed By: emilsjolander Differential Revision: D6759564 fbshipit-source-id: 810dc8a9730fb330760d2aedecafcea81cf25cb1
1 parent f49f793 commit ff2658c

17 files changed

+23
-21
lines changed

ReactAndroid/src/main/java/com/facebook/yoga/YogaAlign.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public enum YogaAlign {
2222
SPACE_BETWEEN(6),
2323
SPACE_AROUND(7);
2424

25-
private int mIntValue;
25+
private final int mIntValue;
2626

2727
YogaAlign(int intValue) {
2828
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaDimension.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public enum YogaDimension {
1616
WIDTH(0),
1717
HEIGHT(1);
1818

19-
private int mIntValue;
19+
private final int mIntValue;
2020

2121
YogaDimension(int intValue) {
2222
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaDirection.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public enum YogaDirection {
1717
LTR(1),
1818
RTL(2);
1919

20-
private int mIntValue;
20+
private final int mIntValue;
2121

2222
YogaDirection(int intValue) {
2323
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaDisplay.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public enum YogaDisplay {
1616
FLEX(0),
1717
NONE(1);
1818

19-
private int mIntValue;
19+
private final int mIntValue;
2020

2121
YogaDisplay(int intValue) {
2222
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaEdge.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public enum YogaEdge {
2323
VERTICAL(7),
2424
ALL(8);
2525

26-
private int mIntValue;
26+
private final int mIntValue;
2727

2828
YogaEdge(int intValue) {
2929
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaExperimentalFeature.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
public enum YogaExperimentalFeature {
1616
WEB_FLEX_BASIS(0);
1717

18-
private int mIntValue;
18+
private final int mIntValue;
1919

2020
YogaExperimentalFeature(int intValue) {
2121
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaFlexDirection.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public enum YogaFlexDirection {
1818
ROW(2),
1919
ROW_REVERSE(3);
2020

21-
private int mIntValue;
21+
private final int mIntValue;
2222

2323
YogaFlexDirection(int intValue) {
2424
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaJustify.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public enum YogaJustify {
2020
SPACE_AROUND(4),
2121
SPACE_EVENLY(5);
2222

23-
private int mIntValue;
23+
private final int mIntValue;
2424

2525
YogaJustify(int intValue) {
2626
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaLogLevel.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ public enum YogaLogLevel {
2020
VERBOSE(4),
2121
FATAL(5);
2222

23-
private int mIntValue;
23+
private final int mIntValue;
2424

2525
YogaLogLevel(int intValue) {
2626
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaMeasureMode.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public enum YogaMeasureMode {
1717
EXACTLY(1),
1818
AT_MOST(2);
1919

20-
private int mIntValue;
20+
private final int mIntValue;
2121

2222
YogaMeasureMode(int intValue) {
2323
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaNode.java

+7-5
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,13 @@ public class YogaNode {
3333
private List<YogaNode> mChildren;
3434
private YogaMeasureFunction mMeasureFunction;
3535
private YogaBaselineFunction mBaselineFunction;
36-
private long mNativePointer;
36+
private final long mNativePointer;
3737
private Object mData;
3838

3939
/* Those flags needs be in sync with YGJNI.cpp */
40-
private final static int MARGIN = 1;
41-
private final static int PADDING = 2;
42-
private final static int BORDER = 4;
40+
private static final int MARGIN = 1;
41+
private static final int PADDING = 2;
42+
private static final int BORDER = 4;
4343

4444
@DoNotStrip
4545
private int mEdgeSetFlag = 0;
@@ -100,6 +100,7 @@ public YogaNode(YogaConfig config) {
100100
}
101101

102102
private native void jni_YGNodeFree(long nativePointer);
103+
@Override
103104
protected void finalize() throws Throwable {
104105
try {
105106
jni_YGNodeFree(mNativePointer);
@@ -170,7 +171,8 @@ public YogaNode removeChildAt(int i) {
170171
return child;
171172
}
172173

173-
public @Nullable
174+
@Nullable
175+
public
174176
YogaNode getParent() {
175177
return mParent;
176178
}

ReactAndroid/src/main/java/com/facebook/yoga/YogaNodeType.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public enum YogaNodeType {
1616
DEFAULT(0),
1717
TEXT(1);
1818

19-
private int mIntValue;
19+
private final int mIntValue;
2020

2121
YogaNodeType(int intValue) {
2222
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaOverflow.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public enum YogaOverflow {
1717
HIDDEN(1),
1818
SCROLL(2);
1919

20-
private int mIntValue;
20+
private final int mIntValue;
2121

2222
YogaOverflow(int intValue) {
2323
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaPositionType.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public enum YogaPositionType {
1616
RELATIVE(0),
1717
ABSOLUTE(1);
1818

19-
private int mIntValue;
19+
private final int mIntValue;
2020

2121
YogaPositionType(int intValue) {
2222
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaPrintOptions.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public enum YogaPrintOptions {
1717
STYLE(2),
1818
CHILDREN(4);
1919

20-
private int mIntValue;
20+
private final int mIntValue;
2121

2222
YogaPrintOptions(int intValue) {
2323
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaUnit.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public enum YogaUnit {
1818
PERCENT(2),
1919
AUTO(3);
2020

21-
private int mIntValue;
21+
private final int mIntValue;
2222

2323
YogaUnit(int intValue) {
2424
mIntValue = intValue;

ReactAndroid/src/main/java/com/facebook/yoga/YogaWrap.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public enum YogaWrap {
1717
WRAP(1),
1818
WRAP_REVERSE(2);
1919

20-
private int mIntValue;
20+
private final int mIntValue;
2121

2222
YogaWrap(int intValue) {
2323
mIntValue = intValue;

0 commit comments

Comments
 (0)