Skip to content

Commit 1cfd256

Browse files
authored
Fix circular module imports causing file size increase (#15231)
* Fix circular module imports causing file size increase
1 parent 669cafb commit 1cfd256

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

packages/react-dom/src/client/ReactDOMComponent.js

+6
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import {canUseDOM} from 'shared/ExecutionEnvironment';
1515
import warningWithoutStack from 'shared/warningWithoutStack';
1616
import type {ReactEventResponderEventType} from 'shared/ReactTypes';
1717
import type {DOMTopLevelEventType} from 'events/TopLevelEventTypes';
18+
import {setListenToResponderEventTypes} from '../events/DOMEventResponderSystem';
1819

1920
import {
2021
getValueForAttribute,
@@ -1337,3 +1338,8 @@ export function listenToEventResponderEventTypes(
13371338
}
13381339
}
13391340
}
1341+
1342+
// We can remove this once the event API is stable and out of a flag
1343+
if (enableEventAPI) {
1344+
setListenToResponderEventTypes(listenToEventResponderEventTypes);
1345+
}

packages/react-dom/src/events/DOMEventResponderSystem.js

+9-2
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,18 @@ import {interactiveUpdates} from 'events/ReactGenericBatching';
2424
import {executeDispatch} from 'events/EventPluginUtils';
2525
import type {Fiber} from 'react-reconciler/src/ReactFiber';
2626

27-
import {listenToEventResponderEventTypes} from '../client/ReactDOMComponent';
2827
import {getClosestInstanceFromNode} from '../client/ReactDOMComponentTree';
2928

3029
import {enableEventAPI} from 'shared/ReactFeatureFlags';
3130

31+
let listenToResponderEventTypesImpl;
32+
33+
export function setListenToResponderEventTypes(
34+
_listenToResponderEventTypesImpl: Function,
35+
) {
36+
listenToResponderEventTypesImpl = _listenToResponderEventTypesImpl;
37+
}
38+
3239
const rootEventTypesToEventComponents: Map<
3340
DOMTopLevelEventType | string,
3441
Set<Fiber>,
@@ -156,7 +163,7 @@ DOMEventResponderContext.prototype.addRootEventTypes = function(
156163
rootEventTypes: Array<ReactEventResponderEventType>,
157164
) {
158165
const element = this.eventTarget.ownerDocument;
159-
listenToEventResponderEventTypes(rootEventTypes, element);
166+
listenToResponderEventTypesImpl(rootEventTypes, element);
160167
const eventComponent = this._fiber;
161168
for (let i = 0; i < rootEventTypes.length; i++) {
162169
const rootEventType = rootEventTypes[i];

0 commit comments

Comments
 (0)