Skip to content

Commit 246d7bf

Browse files
authored
Enable suspenseCallback on React Native (#29210)
## Summary suspenseCallback feature has proved to be useful for FB Web. Let's look at enabling the feature for the React Native build. ## How did you test this change? Will sync the react changes with a React Native build and will verify that performance logging is correctly notified of suspense promises during the suspense callback.
1 parent e44685e commit 246d7bf

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/react-reconciler/src/__tests__/ReactSuspenseCallback-test.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe('ReactSuspense', () => {
4646

4747
// Warning don't fire in production, so this test passes in prod even if
4848
// the suspenseCallback feature is not enabled
49-
// @gate www || !__DEV__
49+
// @gate enableSuspenseCallback || !__DEV__
5050
it('check type', async () => {
5151
const {PromiseComp} = createThenable();
5252

@@ -71,7 +71,7 @@ describe('ReactSuspense', () => {
7171
await expect(async () => await waitForAll([])).toErrorDev([]);
7272
});
7373

74-
// @gate www
74+
// @gate enableSuspenseCallback
7575
it('1 then 0 suspense callback', async () => {
7676
const {promise, resolve, PromiseComp} = createThenable();
7777

@@ -98,7 +98,7 @@ describe('ReactSuspense', () => {
9898
expect(ops).toEqual([]);
9999
});
100100

101-
// @gate www
101+
// @gate enableSuspenseCallback
102102
it('2 then 1 then 0 suspense callback', async () => {
103103
const {
104104
promise: promise1,
@@ -145,7 +145,7 @@ describe('ReactSuspense', () => {
145145
expect(ops).toEqual([]);
146146
});
147147

148-
// @gate www
148+
// @gate enableSuspenseCallback
149149
it('nested suspense promises are reported only for their tier', async () => {
150150
const {promise, PromiseComp} = createThenable();
151151

@@ -177,7 +177,7 @@ describe('ReactSuspense', () => {
177177
expect(ops2).toEqual([new Set([promise])]);
178178
});
179179

180-
// @gate www
180+
// @gate enableSuspenseCallback
181181
it('competing suspense promises', async () => {
182182
const {
183183
promise: promise1,

packages/shared/forks/ReactFeatureFlags.native-fb.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ export const enableScopeAPI = false;
8080
export const enableServerComponentLogs = true;
8181
export const enableSuspenseAvoidThisFallback = false;
8282
export const enableSuspenseAvoidThisFallbackFizz = false;
83-
export const enableSuspenseCallback = false;
83+
export const enableSuspenseCallback = true;
8484
export const enableTaint = true;
8585
export const enableTransitionTracing = false;
8686
export const enableTrustedTypesIntegration = false;

0 commit comments

Comments
 (0)