Skip to content

Commit 2716d91

Browse files
sebmarkbageacdlite
authored andcommitted
Reset didReceiveUpdate in beginWork (#16359)
This is a bad bug. It means that we sometimes inherit didReceiveUpdate from a previous component's begin. Effectively this only means that we're overrendering in some cases. We should refactor to get rid of this as a global flag.
1 parent 9449f8b commit 2716d91

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/react-reconciler/src/ReactFiberBeginWork.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2846,6 +2846,8 @@ function beginWork(
28462846
workInProgress,
28472847
renderExpirationTime,
28482848
);
2849+
} else {
2850+
didReceiveUpdate = false;
28492851
}
28502852
} else {
28512853
didReceiveUpdate = false;

0 commit comments

Comments
 (0)