[compiler] Repro: updates to globals should be retained

ghstack-source-id: 7ee813c0d72e3c752b299f63bfcec3647b022544
Pull Request resolved: #30470

Author: mofeiZ

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/bug-invalid-update-global-should-bailout.expect.md

@@ -0,0 +1,32 @@
+
+## Input
+
+```javascript
+let renderCount = 0;
+function useFoo() {
+  renderCount += 1;
+  return renderCount;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: useFoo,
+  params: [],
+};
+
+```
+
+## Code
+
+```javascript
+let renderCount = 0;
+function useFoo() {
+  return renderCount;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: useFoo,
+  params: [],
+};
+
+```
+      

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/bug-invalid-update-global-should-bailout.tsx

@@ -0,0 +1,10 @@
+let renderCount = 0;
+function useFoo() {
+  renderCount += 1;
+  return renderCount;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: useFoo,
+  params: [],
+};

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/bug-update-global-in-callback.expect.md

@@ -0,0 +1,52 @@
+
+## Input
+
+```javascript
+import {Stringify} from 'shared-runtime';
+
+let renderCount = 0;
+function Foo() {
+  const cb = () => {
+    renderCount += 1;
+    return renderCount;
+  };
+  return <Stringify cb={cb} shouldInvokeFns={true} />;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Foo,
+  params: [{}],
+};
+
+```
+
+## Code
+
+```javascript
+import { c as _c } from "react/compiler-runtime";
+import { Stringify } from "shared-runtime";
+
+let renderCount = 0;
+function Foo() {
+  const $ = _c(1);
+  const cb = _temp;
+  let t0;
+  if ($[0] === Symbol.for("react.memo_cache_sentinel")) {
+    t0 = <Stringify cb={cb} shouldInvokeFns={true} />;
+    $[0] = t0;
+  } else {
+    t0 = $[0];
+  }
+  return t0;
+}
+function _temp() {
+  return renderCount;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Foo,
+  params: [{}],
+};
+
+```
+      

compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/bug-update-global-in-callback.tsx

@@ -0,0 +1,15 @@
+import {Stringify} from 'shared-runtime';
+
+let renderCount = 0;
+function Foo() {
+  const cb = () => {
+    renderCount += 1;
+    return renderCount;
+  };
+  return <Stringify cb={cb} shouldInvokeFns={true} />;
+}
+
+export const FIXTURE_ENTRYPOINT = {
+  fn: Foo,
+  params: [{}],
+};

compiler/packages/snap/src/SproutTodoFilter.ts

@@ -484,6 +484,8 @@ const skipFilter = new Set([
   'rules-of-hooks/rules-of-hooks-69521d94fa03',
 
   // bugs
+  'bug-invalid-update-global-should-bailout',
+  'bug-update-global-in-callback',
   'bug-invalid-hoisting-functionexpr',
   'original-reactive-scopes-fork/bug-nonmutating-capture-in-unsplittable-memo-block',
   'original-reactive-scopes-fork/bug-hoisted-declaration-with-scope',