Skip to content

Commit 441d014

Browse files
author
Brian Vaughn
committed
Cleaned up some extnesions build script stuff
1 parent 380da5f commit 441d014

File tree

18 files changed

+2598
-97
lines changed

18 files changed

+2598
-97
lines changed

packages/react-devtools-core/webpack.backend.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
const {resolve} = require('path');
22
const {DefinePlugin} = require('webpack');
3-
const {getGitHubURL, getVersionString} = require('../../shells/utils');
3+
const {
4+
getGitHubURL,
5+
getVersionString,
6+
} = require('react-devtools-extensions/utils');
47

58
const NODE_ENV = process.env.NODE_ENV;
69
if (!NODE_ENV) {

packages/react-devtools-core/webpack.standalone.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
const {resolve} = require('path');
22
const {DefinePlugin} = require('webpack');
3-
const {getGitHubURL, getVersionString} = require('../../shells/utils');
3+
const {
4+
getGitHubURL,
5+
getVersionString,
6+
} = require('react-devtools-extensions/utils');
47

58
const NODE_ENV = process.env.NODE_ENV;
69
if (!NODE_ENV) {
Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,17 @@
1-
This repo is a work-in-progress rewrite of the [React DevTools extension](https://github.com/facebook/react-devtools). A demo of the beta extension can be found online at [react-devtools-experimental.now.sh](https://react-devtools-experimental.now.sh/).
1+
This is the source code for the React DevTools browser extension.
22

33
# Installation
44

5-
Installation instructions are available online as well:
6-
* [Chrome](https://react-devtools-experimental-chrome.now.sh/)
7-
* [Firefox](https://react-devtools-experimental-firefox.now.sh/)
5+
The easiest way to install this extension is as a browser add-on:
6+
* [Chrome web store](https://chrome.google.com/webstore/detail/react-developer-tools/fmkadmapgofadopljbjfkapdkoienihi?hl=en)
7+
* [Firefox Add-ons](https://addons.mozilla.org/en-US/firefox/addon/react-devtools/)
88

9-
Or you can build and install from source:
10-
```sh
11-
git clone [email protected]:bvaughn/react-devtools-experimental.git
12-
13-
cd react-devtools-experimental
9+
# Build
1410

11+
You can also build and install from source:
12+
```sh
1513
yarn install
1614

17-
yarn build:extension:chrome # builds at "shells/browser/chrome/build"
18-
yarn build:extension:firefox # builds at "shells/browser/firefox/build"
15+
yarn build:extension:chrome # builds at "packages/react-devtools-extensions/chrome/build"
16+
yarn build:extension:firefox # builds at "packages/react-devtools-extensions/firefox/build"
1917
```
20-
21-
# Support
22-
23-
As this extension is in a beta period, it is not officially supported. However if you find a bug, we'd appreciate you reporting it as a [GitHub issue](https://github.com/bvaughn/react-devtools-experimental/issues/new) with repro instructions.

packages/react-devtools-extensions/babel.config.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
const chromeManifest = require('./shells/browser/chrome/manifest.json');
2-
const firefoxManifest = require('./shells/browser/firefox/manifest.json');
1+
const chromeManifest = require('./chrome/manifest.json');
2+
const firefoxManifest = require('./firefox/manifest.json');
33

44
const minChromeVersion = parseInt(chromeManifest.minimum_chrome_version, 10);
55
const minFirefoxVersion = parseInt(

packages/react-devtools-extensions/build.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const {execSync} = require('child_process');
77
const {readFileSync, writeFileSync, createWriteStream} = require('fs');
88
const {copy, ensureDir, move, remove} = require('fs-extra');
99
const {join} = require('path');
10-
const {getGitCommit} = require('../../utils');
10+
const {getGitCommit} = require('./utils');
1111

1212
// These files are copied along with Webpack-bundled files
1313
// to produce the final web extension
@@ -27,7 +27,6 @@ const build = async (tempPath, manifestPath) => {
2727
__dirname,
2828
'..',
2929
'..',
30-
'..',
3130
'node_modules',
3231
'.bin',
3332
'webpack',

packages/react-devtools-extensions/chrome/build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const {execSync} = require('child_process');
77
const {existsSync} = require('fs');
88
const {isAbsolute, join, relative} = require('path');
99
const {argv} = require('yargs');
10-
const build = require('../shared/build');
10+
const build = require('../build');
1111

1212
const main = async () => {
1313
const {crx, keyPath} = argv;

packages/react-devtools-extensions/chrome/deploy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
'use strict';
44

5-
const deploy = require('../shared/deploy');
5+
const deploy = require('../deploy');
66

77
const main = async () => await deploy('chrome');
88

packages/react-devtools-extensions/deploy.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ <h3>
2222
</h3>
2323

2424
<p>
25-
This is a preview build of an <a href="https://github.com/bvaughn/react-devtools-experimental">unreleased DevTools extension</a>.
25+
This is a preview build of an <a href="https://github.com/facebook/react/tree/master/packages/react-devtools-extensions">unreleased DevTools extension</a>.
2626
It has no developer support.
2727
</p>
2828

@@ -34,7 +34,7 @@ <h2>Installation instructions</h2>
3434

3535
<h2>Bug reports</h2>
3636
<p>
37-
Please report bugs as <a href="https://github.com/bvaughn/react-devtools-experimental/issues/new?labels=bug">GitHub issues</a>.
37+
Please report bugs as <a href="https://github.com/facebook/react/issues/new?labels=Component:%20Developer%20Tools">GitHub issues</a>.
3838
Please include all of the info required to reproduce the bug (e.g. links, code, instructions).
3939
</p>
4040

packages/react-devtools-extensions/deploy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ const {readFileSync, writeFileSync} = require('fs');
77
const {join} = require('path');
88

99
const main = async buildId => {
10-
const root = join(__dirname, '..', buildId);
10+
const root = join(__dirname, buildId);
1111
const buildPath = join(root, 'build');
1212

1313
execSync(`node ${join(root, './build')}`, {

packages/react-devtools-extensions/firefox/build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
'use strict';
44

55
const chalk = require('chalk');
6-
const build = require('../shared/build');
6+
const build = require('../build');
77

88
const main = async () => {
99
await build('firefox');

packages/react-devtools-extensions/firefox/deploy.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
'use strict';
44

5-
const deploy = require('../shared/deploy');
5+
const deploy = require('../deploy');
66

77
const main = async () => await deploy('firefox');
88

packages/react-devtools-extensions/package.json

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,14 @@
22

33
"name": "react-devtools-extensions",
44
"version": "0.0.0",
5-
"private": true
5+
"private": true,
6+
"devDependencies": {
7+
"babel-loader": "^8.0.4",
8+
"css-loader": "^1.0.1",
9+
"raw-loader": "^3.1.0",
10+
"style-loader": "^0.23.1",
11+
"webpack": "^4.26.0",
12+
"webpack-cli": "^3.1.2",
13+
"webpack-dev-server": "^3.3.1"
14+
}
615
}

packages/react-devtools-extensions/utils.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ function getGitHubURL() {
2626

2727
function getVersionString() {
2828
const packageVersion = JSON.parse(
29-
readFileSync(resolve(__dirname, '../package.json')),
29+
readFileSync(
30+
resolve(__dirname, '..', 'react-devtools-core', './package.json'),
31+
),
3032
).version;
3133

3234
const commit = getGitCommit();

packages/react-devtools-extensions/webpack.backend.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const {resolve} = require('path');
44
const {DefinePlugin} = require('webpack');
5-
const {getGitHubURL, getVersionString} = require('../utils');
5+
const {getGitHubURL, getVersionString} = require('./utils');
66

77
const NODE_ENV = process.env.NODE_ENV;
88
if (!NODE_ENV) {

packages/react-devtools-extensions/webpack.config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
const {resolve} = require('path');
44
const {DefinePlugin} = require('webpack');
5-
const {getGitHubURL, getVersionString} = require('../utils');
5+
const {getGitHubURL, getVersionString} = require('./utils');
66

77
const NODE_ENV = process.env.NODE_ENV;
88
if (!NODE_ENV) {

packages/react-devtools-inline/webpack.config.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
const {resolve} = require('path');
22
const {DefinePlugin} = require('webpack');
3-
const {getGitHubURL, getVersionString} = require('../../shells/utils');
3+
const {
4+
getGitHubURL,
5+
getVersionString,
6+
} = require('react-devtools-extensions/utils');
47

58
const NODE_ENV = process.env.NODE_ENV;
69
if (!NODE_ENV) {

packages/react-devtools-shell/webpack.config.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
const {resolve} = require('path');
22
const {DefinePlugin} = require('webpack');
3-
const {getGitHubURL, getVersionString} = require('../utils');
3+
const {
4+
getGitHubURL,
5+
getVersionString,
6+
} = require('react-devtools-extensions/utils');
47

58
const NODE_ENV = process.env.NODE_ENV;
69
if (!NODE_ENV) {

0 commit comments

Comments
 (0)