Skip to content

Commit 4ddcb8e

Browse files
gaearonBrian Vaughn
authored and
Brian Vaughn
committed
[DevTools] Remove Welcome dialog (#16834)
1 parent 924a305 commit 4ddcb8e

File tree

6 files changed

+0
-119
lines changed

6 files changed

+0
-119
lines changed

packages/react-devtools-core/src/standalone.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ let nodeWaitingToConnectHTML: string = '';
4040
let projectRoots: Array<string> = [];
4141
let statusListener: StatusListener = (message: string) => {};
4242

43-
// Unlike browser extension users, people using the standalone have actively installed version 4,
44-
// So we probably don't need to show them a changelog notice.
45-
// We should give embedded users (e.g. Nuclide, Sonar) a way of showing this dialog though.
46-
let showWelcomeToTheNewDevToolsDialog: boolean = false;
47-
4843
function setContentDOMNode(value: HTMLElement) {
4944
node = value;
5045

@@ -63,11 +58,6 @@ function setStatusListener(value: StatusListener) {
6358
return DevtoolsUI;
6459
}
6560

66-
function setShowWelcomeToTheNewDevToolsDialog(value: boolean) {
67-
showWelcomeToTheNewDevToolsDialog = value;
68-
return DevtoolsUI;
69-
}
70-
7161
let bridge: FrontendBridge | null = null;
7262
let store: Store | null = null;
7363
let root = null;
@@ -108,7 +98,6 @@ function reload() {
10898
bridge: ((bridge: any): FrontendBridge),
10999
canViewElementSourceFunction,
110100
showTabBar: true,
111-
showWelcomeToTheNewDevToolsDialog,
112101
store: ((store: any): Store),
113102
warnIfLegacyBackendDetected: true,
114103
viewElementSourceFunction,
@@ -318,7 +307,6 @@ const DevtoolsUI = {
318307
connectToSocket,
319308
setContentDOMNode,
320309
setProjectRoots,
321-
setShowWelcomeToTheNewDevToolsDialog,
322310
setStatusListener,
323311
startServer,
324312
};

packages/react-devtools-extensions/src/main.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,6 @@ function createPanelIfReactLoaded() {
161161
overrideTab,
162162
profilerPortalContainer,
163163
showTabBar: false,
164-
showWelcomeToTheNewDevToolsDialog: true,
165164
store,
166165
viewElementSourceFunction,
167166
}),

packages/react-devtools-shared/src/devtools/views/DevTools.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import {ProfilerContextController} from './Profiler/ProfilerContext';
2525
import {ModalDialogContextController} from './ModalDialog';
2626
import ReactLogo from './ReactLogo';
2727
import WarnIfLegacyBackendDetected from './WarnIfLegacyBackendDetected';
28-
import ShowWelcomeToTheNewDevToolsDialog from './ShowWelcomeToTheNewDevToolsDialog';
2928

3029
import styles from './DevTools.css';
3130

@@ -50,7 +49,6 @@ export type Props = {|
5049
canViewElementSourceFunction?: ?CanViewElementSource,
5150
defaultTab?: TabID,
5251
showTabBar?: boolean,
53-
showWelcomeToTheNewDevToolsDialog?: boolean,
5452
store: Store,
5553
warnIfLegacyBackendDetected?: boolean,
5654
viewElementSourceFunction?: ?ViewElementSource,
@@ -92,7 +90,6 @@ export default function DevTools({
9290
overrideTab,
9391
profilerPortalContainer,
9492
showTabBar = false,
95-
showWelcomeToTheNewDevToolsDialog = false,
9693
store,
9794
warnIfLegacyBackendDetected = false,
9895
viewElementSourceFunction,
@@ -167,9 +164,6 @@ export default function DevTools({
167164
</ViewElementSourceContext.Provider>
168165
</SettingsContextController>
169166
{warnIfLegacyBackendDetected && <WarnIfLegacyBackendDetected />}
170-
{showWelcomeToTheNewDevToolsDialog && (
171-
<ShowWelcomeToTheNewDevToolsDialog />
172-
)}
173167
</ModalDialogContextController>
174168
</StoreContext.Provider>
175169
</BridgeContext.Provider>

packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.css

Lines changed: 0 additions & 26 deletions
This file was deleted.

packages/react-devtools-shared/src/devtools/views/ShowWelcomeToTheNewDevToolsDialog.js

Lines changed: 0 additions & 73 deletions
This file was deleted.

packages/react-devtools-shell/src/devtools.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ inject('dist/app.js', () => {
5656
createElement(DevTools, {
5757
browserTheme: 'light',
5858
showTabBar: true,
59-
showWelcomeToTheNewDevToolsDialog: true,
6059
warnIfLegacyBackendDetected: true,
6160
}),
6261
);

0 commit comments

Comments
 (0)