Skip to content

Commit 6115286

Browse files
committed
[Fiber] Call life-cycles with a react-stack-bottom-frame stack frame (#30429)
Stacked on #30427. Most hooks and such are called inside renders which already have these on the stack but life-cycles that call out on them are useful to cut off too. Typically we don't create JSX in here so they wouldn't be part of owner stacks anyway but they can be apart of plain stacks such as the ones prefixes to console logs or printed by error dialogs. This lets us cut off any React internals below. This should really be possible using just ignore listing too ideally. At this point we should maybe just build a Babel plugin that lets us annotate a function to need to have this name. DiffTrain build for [da4abf0](da4abf0)
1 parent 288b7b7 commit 6115286

34 files changed

+4844
-4452
lines changed

compiled/facebook-www/REVISION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
9cc0f6e68de2b83b11d1fb2b514d2f508c2da6f7
1+
da4abf0047cf6dc6d9bff505bd93815264c8c3b7
+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
9cc0f6e68de2b83b11d1fb2b514d2f508c2da6f7
1+
da4abf0047cf6dc6d9bff505bd93815264c8c3b7

compiled/facebook-www/React-dev.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1993,7 +1993,7 @@ __DEV__ &&
19931993
exports.useTransition = function () {
19941994
return resolveDispatcher().useTransition();
19951995
};
1996-
exports.version = "19.0.0-www-classic-9cc0f6e6-20240723";
1996+
exports.version = "19.0.0-www-classic-da4abf00-20240723";
19971997
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19981998
"function" ===
19991999
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -1973,7 +1973,7 @@ __DEV__ &&
19731973
exports.useTransition = function () {
19741974
return resolveDispatcher().useTransition();
19751975
};
1976-
exports.version = "19.0.0-www-modern-9cc0f6e6-20240723";
1976+
exports.version = "19.0.0-www-modern-da4abf00-20240723";
19771977
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
19781978
"function" ===
19791979
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -662,4 +662,4 @@ exports.useSyncExternalStore = function (
662662
exports.useTransition = function () {
663663
return ReactSharedInternals.H.useTransition();
664664
};
665-
exports.version = "19.0.0-www-classic-9cc0f6e6-20240723";
665+
exports.version = "19.0.0-www-classic-da4abf00-20240723";

compiled/facebook-www/React-prod.modern.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -662,4 +662,4 @@ exports.useSyncExternalStore = function (
662662
exports.useTransition = function () {
663663
return ReactSharedInternals.H.useTransition();
664664
};
665-
exports.version = "19.0.0-www-modern-9cc0f6e6-20240723";
665+
exports.version = "19.0.0-www-modern-da4abf00-20240723";

compiled/facebook-www/React-profiling.classic.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ exports.useSyncExternalStore = function (
666666
exports.useTransition = function () {
667667
return ReactSharedInternals.H.useTransition();
668668
};
669-
exports.version = "19.0.0-www-classic-9cc0f6e6-20240723";
669+
exports.version = "19.0.0-www-classic-da4abf00-20240723";
670670
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
671671
"function" ===
672672
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -666,7 +666,7 @@ exports.useSyncExternalStore = function (
666666
exports.useTransition = function () {
667667
return ReactSharedInternals.H.useTransition();
668668
};
669-
exports.version = "19.0.0-www-modern-9cc0f6e6-20240723";
669+
exports.version = "19.0.0-www-modern-da4abf00-20240723";
670670
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
671671
"function" ===
672672
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)