Skip to content

Commit 68fb580

Browse files
authored
Remove unstable_ prefix in various internal uses (#17146)
* Rename unstable_createRoot in DevTools * Rename createSyncRoot in warning
1 parent 3059ab3 commit 68fb580

File tree

7 files changed

+11
-11
lines changed

7 files changed

+11
-11
lines changed

packages/react-devtools-core/src/standalone.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
// $FlowFixMe Flow does not yet know about flushSync()
1313
flushSync,
1414
// $FlowFixMe Flow does not yet know about createRoot()
15-
unstable_createRoot as createRoot,
15+
createRoot,
1616
} from 'react-dom';
1717
import Bridge from 'react-devtools-shared/src/bridge';
1818
import Store from 'react-devtools-shared/src/devtools/store';

packages/react-devtools-extensions/src/main.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
/* global chrome */
22

33
import {createElement} from 'react';
4-
import {unstable_createRoot as createRoot, flushSync} from 'react-dom';
4+
import {createRoot, flushSync} from 'react-dom';
55
import Bridge from 'react-devtools-shared/src/bridge';
66
import Store from 'react-devtools-shared/src/devtools/store';
77
import {

packages/react-devtools-inline/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ const contentWindow = iframe.contentWindow;
6060
const DevTools = initialize(contentWindow);
6161
```
6262

63-
<sup>3</sup> Because the DevTools interface makes use of several new React APIs (e.g. suspense, concurrent mode) it should be rendered using either `ReactDOM.unstable_createRoot` or `ReactDOM.unstable_createSyncRoot`. **It should not be rendered with `ReactDOM.render`.**
63+
<sup>3</sup> Because the DevTools interface makes use of several new React APIs (e.g. suspense, concurrent mode) it should be rendered using either `ReactDOM.createRoot` or `ReactDOM.createSyncRoot`. **It should not be rendered with `ReactDOM.render`.**
6464

6565
## Examples
6666

@@ -92,8 +92,8 @@ initializeBackend(contentWindow);
9292
const DevTools = initializeFrontend(contentWindow);
9393

9494
// <DevTools /> interface can be rendered in the parent window at any time now...
95-
// Be sure to use either ReactDOM.unstable_createRoot()
96-
// or ReactDOM.unstable_createSyncRoot() to render this component.
95+
// Be sure to use either ReactDOM.createRoot()
96+
// or ReactDOM.createSyncRoot() to render this component.
9797

9898
// Let the backend know the frontend is ready and listening.
9999
activateBackend(contentWindow);
@@ -136,8 +136,8 @@ const { contentWindow } = iframe;
136136

137137
// Initialize DevTools UI to listen to the iframe.
138138
// This returns a React component we can render anywhere in the main window.
139-
// Be sure to use either ReactDOM.unstable_createRoot()
140-
// or ReactDOM.unstable_createSyncRoot() to render this component.
139+
// Be sure to use either ReactDOM.createRoot()
140+
// or ReactDOM.createSyncRoot() to render this component.
141141
const DevTools = initialize(contentWindow);
142142

143143
// Let the backend know to initialize itself.

packages/react-devtools-shell/src/app/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import {createElement} from 'react';
66
import {
77
// $FlowFixMe Flow does not yet know about createRoot()
8-
unstable_createRoot as createRoot,
8+
createRoot,
99
} from 'react-dom';
1010
import DeeplyNestedComponents from './DeeplyNestedComponents';
1111
import Iframe from './Iframe';

packages/react-devtools-shell/src/devtools.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import {createElement} from 'react';
44
// $FlowFixMe Flow does not yet know about createRoot()
5-
import {unstable_createRoot as createRoot} from 'react-dom';
5+
import {createRoot} from 'react-dom';
66
import {
77
activate as activateBackend,
88
initialize as initializeBackend,

packages/react-dom/src/__tests__/ReactDOMServerPartialHydration-test.internal.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,7 +344,7 @@ describe('ReactDOMServerPartialHydration', () => {
344344
}).toWarnDev(
345345
'Warning: Cannot hydrate Suspense in legacy mode. Switch from ' +
346346
'ReactDOM.hydrate(element, container) to ' +
347-
'ReactDOM.unstable_createSyncRoot(container, { hydrate: true })' +
347+
'ReactDOM.createSyncRoot(container, { hydrate: true })' +
348348
'.render(element) or remove the Suspense components from the server ' +
349349
'rendered components.' +
350350
'\n in Suspense (at **)' +

packages/react-reconciler/src/ReactFiberBeginWork.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1972,7 +1972,7 @@ function mountDehydratedSuspenseComponent(
19721972
false,
19731973
'Cannot hydrate Suspense in legacy mode. Switch from ' +
19741974
'ReactDOM.hydrate(element, container) to ' +
1975-
'ReactDOM.unstable_createSyncRoot(container, { hydrate: true })' +
1975+
'ReactDOM.createSyncRoot(container, { hydrate: true })' +
19761976
'.render(element) or remove the Suspense components from ' +
19771977
'the server rendered components.',
19781978
);

0 commit comments

Comments
 (0)