Skip to content

Commit 79e462f

Browse files
committed
Externalize Scheduler in noop and test bundles
I also noticed we don't need to regenerator runtime in noop anymore.
1 parent cd6932c commit 79e462f

File tree

1 file changed

+5
-44
lines changed

1 file changed

+5
-44
lines changed

scripts/rollup/bundles.js

Lines changed: 5 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -281,15 +281,15 @@ const bundles = [
281281
moduleType: RENDERER,
282282
entry: 'react-test-renderer',
283283
global: 'ReactTestRenderer',
284-
externals: ['react'],
284+
externals: ['react', 'scheduler'],
285285
},
286286

287287
{
288288
bundleTypes: [FB_WWW_DEV, NODE_DEV, NODE_PROD, UMD_DEV, UMD_PROD],
289289
moduleType: NON_FIBER_RENDERER,
290290
entry: 'react-test-renderer/shallow',
291291
global: 'ReactShallowRenderer',
292-
externals: ['react'],
292+
externals: ['react', 'scheduler'],
293293
},
294294

295295
/******* React Noop Renderer (used for tests) *******/
@@ -298,20 +298,7 @@ const bundles = [
298298
moduleType: RENDERER,
299299
entry: 'react-noop-renderer',
300300
global: 'ReactNoopRenderer',
301-
externals: ['react', 'expect'],
302-
// React Noop uses generators. However GCC currently
303-
// breaks when we attempt to use them in the output.
304-
// So we precompile them with regenerator, and include
305-
// it as a runtime dependency of React Noop. In practice
306-
// this isn't an issue because React Noop is only used
307-
// in our tests. We wouldn't want to do this for any
308-
// public package though.
309-
babel: opts =>
310-
Object.assign({}, opts, {
311-
plugins: opts.plugins.concat([
312-
require.resolve('babel-plugin-transform-regenerator'),
313-
]),
314-
}),
301+
externals: ['react', 'scheduler', 'expect'],
315302
},
316303

317304
/******* React Noop Persistent Renderer (used for tests) *******/
@@ -320,20 +307,7 @@ const bundles = [
320307
moduleType: RENDERER,
321308
entry: 'react-noop-renderer/persistent',
322309
global: 'ReactNoopRendererPersistent',
323-
externals: ['react', 'expect'],
324-
// React Noop uses generators. However GCC currently
325-
// breaks when we attempt to use them in the output.
326-
// So we precompile them with regenerator, and include
327-
// it as a runtime dependency of React Noop. In practice
328-
// this isn't an issue because React Noop is only used
329-
// in our tests. We wouldn't want to do this for any
330-
// public package though.
331-
babel: opts =>
332-
Object.assign({}, opts, {
333-
plugins: opts.plugins.concat([
334-
require.resolve('babel-plugin-transform-regenerator'),
335-
]),
336-
}),
310+
externals: ['react', 'scheduler', 'expect'],
337311
},
338312

339313
/******* React Noop Server Renderer (used for tests) *******/
@@ -342,20 +316,7 @@ const bundles = [
342316
moduleType: RENDERER,
343317
entry: 'react-noop-renderer/server',
344318
global: 'ReactNoopRendererServer',
345-
externals: ['react', 'expect'],
346-
// React Noop uses generators. However GCC currently
347-
// breaks when we attempt to use them in the output.
348-
// So we precompile them with regenerator, and include
349-
// it as a runtime dependency of React Noop. In practice
350-
// this isn't an issue because React Noop is only used
351-
// in our tests. We wouldn't want to do this for any
352-
// public package though.
353-
babel: opts =>
354-
Object.assign({}, opts, {
355-
plugins: opts.plugins.concat([
356-
require.resolve('babel-plugin-transform-regenerator'),
357-
]),
358-
}),
319+
externals: ['react', 'scheduler', 'expect'],
359320
},
360321

361322
/******* React Reconciler *******/

0 commit comments

Comments
 (0)