Skip to content

Commit 7dd6b9e

Browse files
authored
[crud] Add enableUseResourceEffectHook flag (#31556)
Adds a new feature flag for `enableUseResourceEffectHook`. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31556). * #31523 * #31557 * __->__ #31556 * #31555
1 parent d8afd1c commit 7dd6b9e

9 files changed

+16
-0
lines changed

packages/shared/ReactFeatureFlags.js

+5
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,11 @@ export const transitionLaneExpirationMs = 5000;
161161
*/
162162
export const enableInfiniteRenderLoopDetection = false;
163163

164+
/**
165+
* Experimental new hook for better managing resources in effects.
166+
*/
167+
export const enableUseResourceEffectHook = false;
168+
164169
// -----------------------------------------------------------------------------
165170
// Ready for next major.
166171
//

packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js

+1
Original file line numberDiff line numberDiff line change
@@ -25,3 +25,4 @@ export const enableShallowPropDiffing = __VARIANT__;
2525
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
2626
export const enableFabricCompleteRootInCommitPhase = __VARIANT__;
2727
export const enableSiblingPrerendering = __VARIANT__;
28+
export const enableUseResourceEffectHook = __VARIANT__;

packages/shared/forks/ReactFeatureFlags.native-fb.js

+1
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ export const {
2525
enableObjectFiber,
2626
enablePersistedModeClonedFlag,
2727
enableShallowPropDiffing,
28+
enableUseResourceEffectHook,
2829
passChildrenWhenCloningPersistedNodes,
2930
enableSiblingPrerendering,
3031
} = dynamicFlags;

packages/shared/forks/ReactFeatureFlags.native-oss.js

+1
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,7 @@ export const syncLaneExpirationMs = 250;
8484
export const transitionLaneExpirationMs = 5000;
8585
export const useModernStrictMode = true;
8686
export const enableSiblingPrerendering = true;
87+
export const enableUseResourceEffectHook = false;
8788

8889
// Profiling Only
8990
export const enableProfilerTimer = __PROFILE__;

packages/shared/forks/ReactFeatureFlags.test-renderer.js

+2
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,8 @@ export const renameElementSymbol = true;
8383
export const enableShallowPropDiffing = false;
8484
export const enableSiblingPrerendering = true;
8585

86+
export const enableUseResourceEffectHook = false;
87+
8688
// TODO: This must be in sync with the main ReactFeatureFlags file because
8789
// the Test Renderer's value must be the same as the one used by the
8890
// react package.

packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js

+1
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ export const transitionLaneExpirationMs = 5000;
8080
export const useModernStrictMode = true;
8181
export const enableFabricCompleteRootInCommitPhase = false;
8282
export const enableSiblingPrerendering = true;
83+
export const enableUseResourceEffectHook = false;
8384

8485
// Flow magic to verify the exports of this file match the original version.
8586
((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.test-renderer.www.js

+2
Original file line numberDiff line numberDiff line change
@@ -94,5 +94,7 @@ export const enableOwnerStacks = false;
9494
export const enableShallowPropDiffing = false;
9595
export const enableSiblingPrerendering = true;
9696

97+
export const enableUseResourceEffectHook = false;
98+
9799
// Flow magic to verify the exports of this file match the original version.
98100
((((null: any): ExportsType): FeatureFlagsType): ExportsType);

packages/shared/forks/ReactFeatureFlags.www-dynamic.js

+2
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ export const enableSchedulingProfiler = __VARIANT__;
4242
export const enableInfiniteRenderLoopDetection = __VARIANT__;
4343
export const enableSiblingPrerendering = __VARIANT__;
4444

45+
export const enableUseResourceEffectHook = __VARIANT__;
46+
4547
// TODO: These flags are hard-coded to the default values used in open source.
4648
// Update the tests so that they pass in either mode, then set these
4749
// to __VARIANT__.

packages/shared/forks/ReactFeatureFlags.www.js

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ export const {
3131
enableSiblingPrerendering,
3232
enableTransitionTracing,
3333
enableTrustedTypesIntegration,
34+
enableUseResourceEffectHook,
3435
favorSafetyOverHydrationPerf,
3536
renameElementSymbol,
3637
retryLaneExpirationMs,

0 commit comments

Comments
 (0)