Skip to content

Commit 810dff6

Browse files
sebmarkbagesebmarkbage
committed
Remove Warning: prefix and toString on console Arguments (#29839)
Basically make `console.error` and `console.warn` behave like normal - when a component stack isn't appended. I need this because I need to be able to print rich logs with the component stack option and to be able to disable instrumentation completely in `console.createTask` environments that don't need it. Currently we can't print logs with richer objects because they're toString:ed first. In practice, pretty much all arguments we log are already toString:ed so it's not necessary anyway. Some might be like a number. So it would only be a problem if some environment can't handle proper consoles but then it's up to that environment to toString it before logging. The `Warning: ` prefix is historic and is both noisy and confusing. It's mostly unnecessary since the UI surrounding `console.error` and `console.warn` tend to have visual treatment around it anyway. However, it's actively misleading when `console.error` gets prefixed with a Warning that we consider an error level. There's an argument to be made that some of our `console.error` don't make the bar for an error but then the argument is to downgrade each of those to `console.warn` - not to brand all our actual error logging with `Warning: `. Apparently something needs to change in React Native before landing this because it depends on the prefix somehow which probably doesn't make sense already. DiffTrain build for commit 2774208.
1 parent 72d1823 commit 810dff6

File tree

16 files changed

+60
-106
lines changed

16 files changed

+60
-106
lines changed

‎compiled-rn/VERSION_NATIVE_FB

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-bf1bb2e5e5-20240610
1+
19.0.0-native-fb-2774208039-20240610

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<da42891998648234a32c9a1ac70d9bce>>
10+
* @generated SignedSource<<e9c8f9f36a45a6dd3249367e7f40a6db>>
1111
*/
1212

1313
"use strict";
@@ -152,18 +152,11 @@ __DEV__ &&
152152
printWarning("error", format, args, Error("react-stack-top-frame"));
153153
}
154154
function printWarning(level, format, args, currentStack) {
155-
var isErrorLogger =
156-
"%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format;
157155
ReactSharedInternals.getCurrentStack &&
158156
((currentStack = ReactSharedInternals.getCurrentStack(currentStack)),
159157
"" !== currentStack &&
160158
((format += "%s"), (args = args.concat([currentStack]))));
161-
isErrorLogger
162-
? args.unshift(format)
163-
: ((args = args.map(function (item) {
164-
return String(item);
165-
})),
166-
args.unshift("Warning: " + format));
159+
args.unshift(format);
167160
Function.prototype.apply.call(console[level], console, args);
168161
}
169162
function _defineProperties(target, props) {
@@ -15049,14 +15042,14 @@ __DEV__ &&
1504915042
scheduleRoot: scheduleRoot,
1505015043
setRefreshHandler: setRefreshHandler,
1505115044
getCurrentFiber: getCurrentFiberForDevTools,
15052-
reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610"
15045+
reconcilerVersion: "19.0.0-native-fb-2774208039-20240610"
1505315046
});
1505415047
})({
1505515048
findFiberByHostInstance: function () {
1505615049
throw Error("TestRenderer does not support findFiberByHostInstance()");
1505715050
},
1505815051
bundleType: 1,
15059-
version: "19.0.0-native-fb-bf1bb2e5e5-20240610",
15052+
version: "19.0.0-native-fb-2774208039-20240610",
1506015053
rendererPackageName: "react-test-renderer"
1506115054
});
1506215055
exports._Scheduler = Scheduler;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9920f84659406d21dcf5429e76df93eb>>
10+
* @generated SignedSource<<db4dd88f7d1228b66c0f9b5647536e42>>
1111
*/
1212

1313
"use strict";
@@ -9336,7 +9336,7 @@ var devToolsConfig$jscomp$inline_1048 = {
93369336
throw Error("TestRenderer does not support findFiberByHostInstance()");
93379337
},
93389338
bundleType: 0,
9339-
version: "19.0.0-native-fb-bf1bb2e5e5-20240610",
9339+
version: "19.0.0-native-fb-2774208039-20240610",
93409340
rendererPackageName: "react-test-renderer"
93419341
};
93429342
var internals$jscomp$inline_1235 = {
@@ -9367,7 +9367,7 @@ var internals$jscomp$inline_1235 = {
93679367
scheduleRoot: null,
93689368
setRefreshHandler: null,
93699369
getCurrentFiber: null,
9370-
reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610"
9370+
reconcilerVersion: "19.0.0-native-fb-2774208039-20240610"
93719371
};
93729372
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
93739373
var hook$jscomp$inline_1236 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<8346d33fcde7920e58c0769c267354c4>>
10+
* @generated SignedSource<<ee84d20386606858c48dfc7bb7fcd98b>>
1111
*/
1212

1313
"use strict";
@@ -9958,7 +9958,7 @@ var devToolsConfig$jscomp$inline_1131 = {
99589958
throw Error("TestRenderer does not support findFiberByHostInstance()");
99599959
},
99609960
bundleType: 0,
9961-
version: "19.0.0-native-fb-bf1bb2e5e5-20240610",
9961+
version: "19.0.0-native-fb-2774208039-20240610",
99629962
rendererPackageName: "react-test-renderer"
99639963
};
99649964
(function (internals) {
@@ -10002,7 +10002,7 @@ var devToolsConfig$jscomp$inline_1131 = {
1000210002
scheduleRoot: null,
1000310003
setRefreshHandler: null,
1000410004
getCurrentFiber: null,
10005-
reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610"
10005+
reconcilerVersion: "19.0.0-native-fb-2774208039-20240610"
1000610006
});
1000710007
exports._Scheduler = Scheduler;
1000810008
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXDEVRuntime-dev.js

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9e2dad0789cdb57b65878831989d6b55>>
10+
* @generated SignedSource<<a7dfd81316b971431720d69e9f261fbf>>
1111
*/
1212

1313
"use strict";
@@ -22,22 +22,13 @@ __DEV__ &&
2222
_key2++
2323
)
2424
args[_key2 - 1] = arguments[_key2];
25-
printWarning("error", format, args, Error("react-stack-top-frame"));
26-
}
27-
function printWarning(level, format, args, currentStack) {
28-
var isErrorLogger =
29-
"%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format;
25+
_len2 = format;
26+
_key2 = Error("react-stack-top-frame");
3027
ReactSharedInternals.getCurrentStack &&
31-
((currentStack = ReactSharedInternals.getCurrentStack(currentStack)),
32-
"" !== currentStack &&
33-
((format += "%s"), (args = args.concat([currentStack]))));
34-
isErrorLogger
35-
? args.unshift(format)
36-
: ((args = args.map(function (item) {
37-
return String(item);
38-
})),
39-
args.unshift("Warning: " + format));
40-
Function.prototype.apply.call(console[level], console, args);
28+
((_key2 = ReactSharedInternals.getCurrentStack(_key2)),
29+
"" !== _key2 && ((_len2 += "%s"), (args = args.concat([_key2]))));
30+
args.unshift(_len2);
31+
Function.prototype.apply.call(console.error, console, args);
4132
}
4233
function getComponentNameFromType(type) {
4334
if (null == type) return null;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/JSXRuntime-dev.js

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<4d095073d7f6f1a36d5b981e9c2a52aa>>
10+
* @generated SignedSource<<1e831dc318079da75149235e0e09d92d>>
1111
*/
1212

1313
"use strict";
@@ -22,22 +22,13 @@ __DEV__ &&
2222
_key2++
2323
)
2424
args[_key2 - 1] = arguments[_key2];
25-
printWarning("error", format, args, Error("react-stack-top-frame"));
26-
}
27-
function printWarning(level, format, args, currentStack) {
28-
var isErrorLogger =
29-
"%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format;
25+
_len2 = format;
26+
_key2 = Error("react-stack-top-frame");
3027
ReactSharedInternals.getCurrentStack &&
31-
((currentStack = ReactSharedInternals.getCurrentStack(currentStack)),
32-
"" !== currentStack &&
33-
((format += "%s"), (args = args.concat([currentStack]))));
34-
isErrorLogger
35-
? args.unshift(format)
36-
: ((args = args.map(function (item) {
37-
return String(item);
38-
})),
39-
args.unshift("Warning: " + format));
40-
Function.prototype.apply.call(console[level], console, args);
28+
((_key2 = ReactSharedInternals.getCurrentStack(_key2)),
29+
"" !== _key2 && ((_len2 += "%s"), (args = args.concat([_key2]))));
30+
args.unshift(_len2);
31+
Function.prototype.apply.call(console.error, console, args);
4132
}
4233
function getComponentNameFromType(type) {
4334
if (null == type) return null;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<c21f501f8b44219eb9f3f5d971634c05>>
10+
* @generated SignedSource<<4e0e4b457140b7f25071b271f8f187d2>>
1111
*/
1212

1313
"use strict";
@@ -55,18 +55,11 @@ __DEV__ &&
5555
printWarning("error", format, args, Error("react-stack-top-frame"));
5656
}
5757
function printWarning(level, format, args, currentStack) {
58-
var isErrorLogger =
59-
"%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format;
6058
ReactSharedInternals.getCurrentStack &&
6159
((currentStack = ReactSharedInternals.getCurrentStack(currentStack)),
6260
"" !== currentStack &&
6361
((format += "%s"), (args = args.concat([currentStack]))));
64-
isErrorLogger
65-
? args.unshift(format)
66-
: ((args = args.map(function (item) {
67-
return String(item);
68-
})),
69-
args.unshift("Warning: " + format));
62+
args.unshift(format);
7063
Function.prototype.apply.call(console[level], console, args);
7164
}
7265
function warnNoop(publicInstance, callerName) {
@@ -1748,7 +1741,7 @@ __DEV__ &&
17481741
exports.useTransition = function () {
17491742
return resolveDispatcher().useTransition();
17501743
};
1751-
exports.version = "19.0.0-native-fb-bf1bb2e5e5-20240610";
1744+
exports.version = "19.0.0-native-fb-2774208039-20240610";
17521745
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
17531746
"function" ===
17541747
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2c83bccf84bb8a9740b77d55bf1f96ca>>
10+
* @generated SignedSource<<138668c29d55fc3ae4dbdcec9581ff7b>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-native-fb-bf1bb2e5e5-20240610";
607+
exports.version = "19.0.0-native-fb-2774208039-20240610";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<2d729030ac0bf8fa0eb464bb2f16e724>>
10+
* @generated SignedSource<<540135ee9c1a9fde97799dda98a4b743>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-native-fb-bf1bb2e5e5-20240610";
611+
exports.version = "19.0.0-native-fb-2774208039-20240610";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
bf1bb2e5e52733a9577848f2913d06edcf24df14
1+
277420803947724b43c47bbc47d3a353553868f1

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<50de4ae8b3ee39790e8c9b7e11f89ad9>>
10+
* @generated SignedSource<<b5fd1f738b9e23ac9f724f39960a3e88>>
1111
*/
1212

1313
"use strict";
@@ -156,18 +156,11 @@ __DEV__ &&
156156
}
157157
}
158158
function printWarning(level, format, args, currentStack) {
159-
var isErrorLogger =
160-
"%s\n\n%s\n" === format || "%o\n\n%s\n\n%s\n" === format;
161159
ReactSharedInternals.getCurrentStack &&
162160
((currentStack = ReactSharedInternals.getCurrentStack(currentStack)),
163161
"" !== currentStack &&
164162
((format += "%s"), (args = args.concat([currentStack]))));
165-
isErrorLogger
166-
? args.unshift(format)
167-
: ((args = args.map(function (item) {
168-
return String(item);
169-
})),
170-
args.unshift("Warning: " + format));
163+
args.unshift(format);
171164
Function.prototype.apply.call(console[level], console, args);
172165
}
173166
function validateEventDispatches(event) {
@@ -16681,12 +16674,12 @@ __DEV__ &&
1668116674
scheduleRoot: scheduleRoot,
1668216675
setRefreshHandler: setRefreshHandler,
1668316676
getCurrentFiber: getCurrentFiberForDevTools,
16684-
reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610"
16677+
reconcilerVersion: "19.0.0-native-fb-2774208039-20240610"
1668516678
});
1668616679
})({
1668716680
findFiberByHostInstance: getInstanceFromNode,
1668816681
bundleType: 1,
16689-
version: "19.0.0-native-fb-bf1bb2e5e5-20240610",
16682+
version: "19.0.0-native-fb-2774208039-20240610",
1669016683
rendererPackageName: "react-native-renderer",
1669116684
rendererConfig: {
1669216685
getInspectorDataForInstance: getInspectorDataForInstance,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<1dd48ba25960696fbbef43b558b17207>>
10+
* @generated SignedSource<<1619271d414b4256cd58ad54d07e0b4a>>
1111
*/
1212

1313
"use strict";
@@ -10591,7 +10591,7 @@ var roots = new Map(),
1059110591
devToolsConfig$jscomp$inline_1125 = {
1059210592
findFiberByHostInstance: getInstanceFromNode,
1059310593
bundleType: 0,
10594-
version: "19.0.0-native-fb-bf1bb2e5e5-20240610",
10594+
version: "19.0.0-native-fb-2774208039-20240610",
1059510595
rendererPackageName: "react-native-renderer",
1059610596
rendererConfig: {
1059710597
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10634,7 +10634,7 @@ var internals$jscomp$inline_1351 = {
1063410634
scheduleRoot: null,
1063510635
setRefreshHandler: null,
1063610636
getCurrentFiber: null,
10637-
reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610"
10637+
reconcilerVersion: "19.0.0-native-fb-2774208039-20240610"
1063810638
};
1063910639
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1064010640
var hook$jscomp$inline_1352 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-profiling.fb.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<db1518fef4ce31ff3695820ce5911be7>>
10+
* @generated SignedSource<<df6f3910cc77174c9921429231bb3527>>
1111
*/
1212

1313
"use strict";
@@ -11297,7 +11297,7 @@ var roots = new Map(),
1129711297
devToolsConfig$jscomp$inline_1206 = {
1129811298
findFiberByHostInstance: getInstanceFromNode,
1129911299
bundleType: 0,
11300-
version: "19.0.0-native-fb-bf1bb2e5e5-20240610",
11300+
version: "19.0.0-native-fb-2774208039-20240610",
1130111301
rendererPackageName: "react-native-renderer",
1130211302
rendererConfig: {
1130311303
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -11353,7 +11353,7 @@ var roots = new Map(),
1135311353
scheduleRoot: null,
1135411354
setRefreshHandler: null,
1135511355
getCurrentFiber: null,
11356-
reconcilerVersion: "19.0.0-native-fb-bf1bb2e5e5-20240610"
11356+
reconcilerVersion: "19.0.0-native-fb-2774208039-20240610"
1135711357
});
1135811358
exports.createPortal = function (children, containerTag) {
1135911359
return createPortal$1(

0 commit comments

Comments
 (0)