Move lazy._result assignment (#14632)

gaearon · web-flow · commit a2fa6eb98d11 · 2019-01-18T21:57:26.000Z
diff --git a/packages/react-reconciler/src/ReactFiberLazyComponent.js b/packages/react-reconciler/src/ReactFiberLazyComponent.js
@@ -47,7 +47,6 @@ export function readLazyComponentType<T>(lazyComponent: LazyComponent<T>): T {
       lazyComponent._status = Pending;
       const ctor = lazyComponent._ctor;
       const thenable = ctor();
-      lazyComponent._result = thenable;
       thenable.then(
         moduleObject => {
           if (lazyComponent._status === Pending) {
@@ -78,6 +77,7 @@ export function readLazyComponentType<T>(lazyComponent: LazyComponent<T>): T {
       if (lazyComponent._status === Resolved) {
         return lazyComponent._result;
       }
+      lazyComponent._result = thenable;
       throw thenable;
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ export function readLazyComponentType<T>(lazyComponent: LazyComponent<T>): T {`
`47`	`47`	`lazyComponent._status = Pending;`
`48`	`48`	`const ctor = lazyComponent._ctor;`
`49`	`49`	`const thenable = ctor();`
`50`		`- lazyComponent._result = thenable;`
`51`	`50`	`thenable.then(`
`52`	`51`	`moduleObject => {`
`53`	`52`	`if (lazyComponent._status === Pending) {`
`@@ -78,6 +77,7 @@ export function readLazyComponentType<T>(lazyComponent: LazyComponent<T>): T {`
`78`	`77`	`if (lazyComponent._status === Resolved) {`
`79`	`78`	`return lazyComponent._result;`
`80`	`79`	`}`
	`80`	`+ lazyComponent._result = thenable;`
`81`	`81`	`throw thenable;`
`82`	`82`	`}`
`83`	`83`	`}`