[work loop] Prevent work loop from being inlined (#16865)

acdlite · web-flow · commit a87d245fc2d0 · 2019-09-23T11:12:47.000-07:00
Uses Closure Compiler's `@noinline` directive. See https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#noinline
diff --git a/packages/react-reconciler/src/ReactFiberWorkLoop.js b/packages/react-reconciler/src/ReactFiberWorkLoop.js
@@ -1422,13 +1422,16 @@ function inferTimeFromExpirationTimeWithSuspenseConfig(
   );
 }
 
+// The work loop is an extremely hot path. Tell Closure not to inline it.
+/** @noinline */
 function workLoopSync() {
   // Already timed out, so perform work without checking if we need to yield.
   while (workInProgress !== null) {
     workInProgress = performUnitOfWork(workInProgress);
   }
 }
 
+/** @noinline */
 function workLoop() {
   // Perform work until Scheduler asks us to yield
   while (workInProgress !== null && !shouldYield()) {

Original file line number	Diff line number	Diff line change
`@@ -1422,13 +1422,16 @@ function inferTimeFromExpirationTimeWithSuspenseConfig(`
`1422`	`1422`	`);`
`1423`	`1423`	`}`
`1424`	`1424`
	`1425`	`+// The work loop is an extremely hot path. Tell Closure not to inline it.`
	`1426`	`+/** @noinline */`
`1425`	`1427`	`function workLoopSync() {`
`1426`	`1428`	`// Already timed out, so perform work without checking if we need to yield.`
`1427`	`1429`	`while (workInProgress !== null) {`
`1428`	`1430`	`workInProgress = performUnitOfWork(workInProgress);`
`1429`	`1431`	`}`
`1430`	`1432`	`}`
`1431`	`1433`
	`1434`	`+/** @noinline */`
`1432`	`1435`	`function workLoop() {`
`1433`	`1436`	`// Perform work until Scheduler asks us to yield`
`1434`	`1437`	`while (workInProgress !== null && !shouldYield()) {`