Fix a bunch of build warnings (#283)

Summary: Pull Request resolved: #283

Reviewed By: strulovich

Differential Revision: D35622876

Pulled By: cgrushko

fbshipit-source-id: 4c09d8d12890f75de63b6a7594e21aa6ad721305

Author: nreid260

core/pom.xml

@@ -148,7 +148,7 @@
         </dependency>
         <dependency>
             <groupId>org.jetbrains.kotlin</groupId>
-            <artifactId>kotlin-stdlib</artifactId>
+            <artifactId>kotlin-stdlib-jdk7</artifactId>
             <version>${kotlin.version}</version>
         </dependency>
         <dependency>

core/src/main/java/com/facebook/ktfmt/format/KotlinInput.kt

@@ -28,6 +28,7 @@ import com.google.googlejavaformat.Input
 import com.google.googlejavaformat.Newlines
 import com.google.googlejavaformat.java.FormatterException
 import com.google.googlejavaformat.java.JavaOutput
+import java.util.LinkedHashMap
 import org.jetbrains.kotlin.com.intellij.openapi.util.text.StringUtil
 import org.jetbrains.kotlin.lexer.KtTokens
 import org.jetbrains.kotlin.psi.KtFile
@@ -107,7 +108,6 @@ class KotlinInput(private val text: String, file: KtFile) : Input() {
    */
   @Throws(FormatterException::class)
   internal fun characterRangeToTokenRange(offset: Int, length: Int): Range<Int> {
-    var length = length
     val requiredLength = offset + length
     if (requiredLength > text.length) {
       throw FormatterException(
@@ -116,14 +116,15 @@ class KotlinInput(private val text: String, file: KtFile) : Input() {
               length,
               requiredLength))
     }
-    when {
-      length < 0 -> return EMPTY_RANGE
-      length == 0 -> // 0 stands for "format the line under the cursor"
-      length = 1
-    }
+    val expandedLength =
+        when {
+          length < 0 -> return EMPTY_RANGE
+          length == 0 -> 1 // 0 stands for "format the line under the cursor"
+          else -> length
+        }
     val enclosed =
         getPositionTokenMap()
-            .subRangeMap(Range.closedOpen(offset, offset + length))
+            .subRangeMap(Range.closedOpen(offset, offset + expandedLength))
             .asMapOfRanges()
             .values
     return if (enclosed.isEmpty()) {
@@ -134,11 +135,11 @@ class KotlinInput(private val text: String, file: KtFile) : Input() {
   }
 
   private fun makePositionToColumnMap(toks: List<KotlinTok>): ImmutableMap<Int, Int> {
-    val builder = ImmutableMap.builder<Int, Int>()
+    val builder = LinkedHashMap<Int, Int>()
     for (tok in toks) {
       builder.put(tok.position, tok.column)
     }
-    return builder.build()
+    return ImmutableMap.copyOf(builder)
   }
 
   private fun buildToks(file: KtFile, fileText: String): ImmutableList<KotlinTok> {

core/src/main/java/com/facebook/ktfmt/format/KotlinInputAstVisitor.kt

@@ -1342,8 +1342,7 @@ class KotlinInputAstVisitor(
     builder.open(ZERO)
     builder.block(blockIndent) {
       builder.breakOp(Doc.FillMode.UNIFIED, "", ZERO)
-      val (enumEntries, nonEnumEntryStatements) =
-          body?.children?.partition { it is KtEnumEntry } ?: fail()
+      val (enumEntries, nonEnumEntryStatements) = body.children.partition { it is KtEnumEntry }
       builder.forcedBreak()
       visitEnumEntries(enumEntries)
 

core/src/main/java/com/facebook/ktfmt/format/Tokenizer.kt

@@ -77,7 +77,6 @@ class Tokenizer(private val fileText: String, val file: KtFile) : KtTreeVisitorV
       }
       is LeafPsiElement -> {
         val elementText = element.text
-        val startIndex = element.startOffset
         val endIndex = element.endOffset
         if (element is PsiWhiteSpace) {
           val matcher = WHITESPACE_NEWLINE_REGEX.matcher(elementText)

core/src/main/java/com/facebook/ktfmt/format/TypeNameClassifier.kt

@@ -124,16 +124,16 @@ object TypeNameClassifier {
         var hasUppercase = false
         var hasLowercase = false
         var first = true
-        for (element in name) {
-          if (!Character.isAlphabetic(element.toInt())) {
+        for (char in name) {
+          if (!Character.isAlphabetic(char.code)) {
             continue
           }
           if (first) {
-            firstUppercase = Character.isUpperCase(element)
+            firstUppercase = Character.isUpperCase(char)
             first = false
           }
-          hasUppercase = hasUppercase or Character.isUpperCase(element)
-          hasLowercase = hasLowercase or Character.isLowerCase(element)
+          hasUppercase = hasUppercase or Character.isUpperCase(char)
+          hasLowercase = hasLowercase or Character.isLowerCase(char)
         }
         return if (firstUppercase) {
           if (hasLowercase) UPPER_CAMEL else UPPERCASE

core/src/main/java/com/facebook/ktfmt/kdoc/KDocCommentsHelper.kt

@@ -86,13 +86,12 @@ class KDocCommentsHelper(private val lineSeparator: String, private val maxLineL
 
   // Wraps and re-indents line comments.
   private fun indentLineComments(lines: List<String>, column0: Int): String {
-    var lines = lines
-    lines = wrapLineComments(lines, column0)
+    val wrappedLines = wrapLineComments(lines, column0)
     val builder = StringBuilder()
-    builder.append(lines[0].trim())
+    builder.append(wrappedLines[0].trim())
     val indentString = Strings.repeat(" ", column0)
-    for (i in 1 until lines.size) {
-      builder.append(lineSeparator).append(indentString).append(lines[i].trim())
+    for (i in 1 until wrappedLines.size) {
+      builder.append(lineSeparator).append(indentString).append(wrappedLines[i].trim())
     }
     return builder.toString()
   }

core/src/test/java/com/facebook/ktfmt/cli/MainTest.kt

@@ -23,6 +23,7 @@ import java.io.PrintStream
 import java.lang.IllegalStateException
 import java.nio.file.Files
 import java.util.concurrent.ForkJoinPool
+import kotlin.io.path.createTempDirectory
 import org.junit.After
 import org.junit.Assert.fail
 import org.junit.Test
@@ -33,7 +34,7 @@ import org.junit.runners.JUnit4
 @RunWith(JUnit4::class)
 class MainTest {
 
-  private val root = createTempDir()
+  private val root = createTempDirectory().toFile()
 
   private val emptyInput = "".byteInputStream()
   private val out = ByteArrayOutputStream()

core/src/test/java/com/facebook/ktfmt/format/FormatterTest.kt

@@ -2253,7 +2253,7 @@ class FormatterTest {
           deduceMaxWidth = true)
 
   @Test
-  fun `handle ? for nullalble types`() =
+  fun `handle qmark for nullalble types`() =
       assertFormatted(
           """
       |fun doItWithNullReturns(a: String, b: String): Int? {