Skip to content

Commit 474c8b4

Browse files
nikhilaravifacebook-github-bot
authored andcommitted
remove bin_size from the settings in the tutorials
Summary: Remove `bin_size` and `max_faces_per_pixel` from being specified. This means the coarse-to-fine rasterization will be used by default and will help avoid confusion with the naive version. Reviewed By: jcjohnson Differential Revision: D20908905 fbshipit-source-id: c181c88e844d888aa81a36870918307961dc1175
1 parent 0fecb2d commit 474c8b4

3 files changed

+3
-12
lines changed

docs/tutorials/camera_position_optimization_with_differentiable_rendering.ipynb

+1-4
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,6 @@
235235
" image_size=256, \n",
236236
" blur_radius=np.log(1. / 1e-4 - 1.) * blend_params.sigma, \n",
237237
" faces_per_pixel=100, \n",
238-
" bin_size = None, # this setting controls whether naive or coarse-to-fine rasterization is used\n",
239-
" max_faces_per_bin = None # this setting is for coarse rasterization\n",
240238
")\n",
241239
"\n",
242240
"# Create a silhouette mesh renderer by composing a rasterizer and a shader. \n",
@@ -254,7 +252,6 @@
254252
" image_size=256, \n",
255253
" blur_radius=0.0, \n",
256254
" faces_per_pixel=1, \n",
257-
" bin_size=0\n",
258255
")\n",
259256
"# We can add a point light in front of the object. \n",
260257
"lights = PointLights(device=device, location=((2.0, 2.0, -2.0),))\n",
@@ -304,7 +301,7 @@
304301
]
305302
},
306303
"metadata": {
307-
"bento_obj_id": "140092634331216",
304+
"bento_obj_id": "139625337525584",
308305
"needs_background": "light"
309306
},
310307
"output_type": "display_data"

docs/tutorials/render_colored_points.ipynb

+2-6
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,7 @@
166166
"raster_settings = PointsRasterizationSettings(\n",
167167
" image_size=512, \n",
168168
" radius = 0.003,\n",
169-
" points_per_pixel = 10,\n",
170-
" bin_size = None,\n",
171-
" max_points_per_bin = None\n",
169+
" points_per_pixel = 10\n",
172170
")\n",
173171
"\n",
174172
"\n",
@@ -247,9 +245,7 @@
247245
"raster_settings = PointsRasterizationSettings(\n",
248246
" image_size=512, \n",
249247
" radius = 0.003,\n",
250-
" points_per_pixel = 10,\n",
251-
" bin_size = None,\n",
252-
" max_points_per_bin = None\n",
248+
" points_per_pixel = 10\n",
253249
")\n",
254250
"\n",
255251
"\n",

docs/tutorials/render_textured_meshes.ipynb

-2
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,6 @@
322322
" image_size=512, \n",
323323
" blur_radius=0.0, \n",
324324
" faces_per_pixel=1, \n",
325-
" bin_size = None, # this setting controls whether naive or coarse-to-fine rasterization is used\n",
326-
" max_faces_per_bin = None # this setting is for coarse rasterization\n",
327325
")\n",
328326
"\n",
329327
"# Place a point light in front of the object. As mentioned above, the front of the cow is facing the \n",

0 commit comments

Comments
 (0)