You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not a breaking issue since the Collection is still supported, but a DeprecationWarning is thrown.
For a new project, where there is a need to change the Settings and inheriting the ones set in this package, can cause confusion or a mix of the two.
In the linked commit, it's easy to see that Collection attributes will overrides the one in Settings.
To Reproduce
Steps to reproduce the behaviour:
make install
make test
Expected behaviour
No warning is raised.
Additional context
After updating the code, I'd suggest bumping the version and update the Readme too, as this is a breaking change.
The text was updated successfully, but these errors were encountered:
Description
In
beanie
1.11, theCollection
configuration class has been unified inSettings
.This is not a breaking issue since the
Collection
is still supported, but aDeprecationWarning
is thrown.For a new project, where there is a need to change the
Settings
and inheriting the ones set in this package, can cause confusion or a mix of the two.In the linked commit, it's easy to see that
Collection
attributes will overrides the one inSettings
.To Reproduce
Steps to reproduce the behaviour:
make install
make test
Expected behaviour
No warning is raised.
Additional context
After updating the code, I'd suggest bumping the version and update the Readme too, as this is a breaking change.
The text was updated successfully, but these errors were encountered: