Skip to content

Update Collection to Settings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vittoriozamboni opened this issue Jun 24, 2022 · 0 comments
Closed

Update Collection to Settings #2

vittoriozamboni opened this issue Jun 24, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@vittoriozamboni
Copy link
Contributor

Description

In beanie 1.11, the Collection configuration class has been unified in Settings.

This is not a breaking issue since the Collection is still supported, but a DeprecationWarning is thrown.
For a new project, where there is a need to change the Settings and inheriting the ones set in this package, can cause confusion or a mix of the two.
In the linked commit, it's easy to see that Collection attributes will overrides the one in Settings.

To Reproduce

Steps to reproduce the behaviour:

  1. make install
  2. make test

test_warnings

Expected behaviour

No warning is raised.

Additional context

After updating the code, I'd suggest bumping the version and update the Readme too, as this is a breaking change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants