Skip to content

Commit c8104d8

Browse files
authored
🔥 Remove logic for development dependencies and Jupyter, it was never documented, and I no longer use that trick (#1355)
1 parent 7ed8694 commit c8104d8

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

‎backend/Dockerfile

+1-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@ RUN curl -sSL https://install.python-poetry.org | POETRY_HOME=/opt/poetry python
1111
# Copy poetry.lock* in case it doesn't exist in the repo
1212
COPY ./pyproject.toml ./poetry.lock* /app/
1313

14-
# Allow installing dev dependencies to run tests
15-
ARG INSTALL_DEV=false
16-
RUN bash -c "if [ $INSTALL_DEV == 'true' ] ; then poetry install --no-root ; else poetry install --no-root --only main ; fi"
14+
RUN poetry install --no-root
1715

1816
ENV PYTHONPATH=/app
1917

‎docker-compose.override.yml

-3
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,9 @@ services:
5858
backend:
5959
restart: "no"
6060
ports:
61-
- "8888:8888"
6261
- "8000:8000"
6362
build:
6463
context: ./backend
65-
args:
66-
INSTALL_DEV: ${INSTALL_DEV-true}
6764
# command: sleep infinity # Infinite loop to keep container alive doing nothing
6865
command:
6966
- fastapi

‎docker-compose.yml

-4
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ services:
4646
image: '${DOCKER_IMAGE_BACKEND?Variable not set}:${TAG-latest}'
4747
build:
4848
context: ./backend
49-
args:
50-
INSTALL_DEV: ${INSTALL_DEV-false}
5149
networks:
5250
- traefik-public
5351
- default
@@ -118,8 +116,6 @@ services:
118116

119117
build:
120118
context: ./backend
121-
args:
122-
INSTALL_DEV: ${INSTALL_DEV-false}
123119
labels:
124120
- traefik.enable=true
125121
- traefik.docker.network=traefik-public

0 commit comments

Comments
 (0)