Skip to content

Commit 04a2d6a

Browse files
simonebgurgunday
andauthored
chore: exclude Node 14 and 16 on macos (#127)
* chore: exclude Node 14 and 16 on macos Related to fastify/.github#37. This is just a proposal, probably not comprehensive of all the places where a similar change may have to occur, simply to capture that this is possible (and I didn't know until now) to exclude combinations, as documented in https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#excluding-matrix-configurations Signed-off-by: Simone Busoli <[email protected]> * remove os matrix from package --------- Signed-off-by: Simone Busoli <[email protected]> Co-authored-by: Gürgün Dayıoğlu <[email protected]>
1 parent a966a7e commit 04a2d6a

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

Diff for: .github/workflows/plugins-ci-package-manager.yml

+2-5
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,13 @@ on:
1212
jobs:
1313
pnpm:
1414
name: pnpm
15-
runs-on: ${{ matrix.os }}
15+
runs-on: ubuntu-latest
1616
permissions:
1717
contents: read
1818
strategy:
1919
matrix:
2020
node-version: ${{ fromJson(inputs.node-versions) }}
21-
os: [ubuntu-latest]
2221
pnpm-version: [8]
23-
2422
steps:
2523
- name: Check out repo
2624
uses: actions/checkout@v4
@@ -45,13 +43,12 @@ jobs:
4543

4644
yarn:
4745
name: Yarn
48-
runs-on: ${{ matrix.os }}
46+
runs-on: ubuntu-latest
4947
permissions:
5048
contents: read
5149
strategy:
5250
matrix:
5351
node-version: ${{ fromJson(inputs.node-versions) }}
54-
os: [ubuntu-latest]
5552
steps:
5653
- name: Check out repo
5754
uses: actions/checkout@v4

Diff for: .github/workflows/plugins-ci.yml

+5
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,11 @@ jobs:
110110
matrix:
111111
node-version: ${{ fromJson(inputs.node-versions) }}
112112
os: [macos-latest, ubuntu-latest, windows-latest]
113+
exclude:
114+
- os: macos-latest
115+
node-version: 14
116+
- os: macos-latest
117+
node-version: 16
113118
steps:
114119
- name: Check out repo
115120
uses: actions/checkout@v4

0 commit comments

Comments
 (0)