Skip to content

Redundant timezone conversion in feast materialize logs #5227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
patilsuraj767 opened this issue Apr 6, 2025 · 2 comments · Fixed by #5243
Closed

Redundant timezone conversion in feast materialize logs #5227

patilsuraj767 opened this issue Apr 6, 2025 · 2 comments · Fixed by #5243
Labels
kind/bug priority/p2

Comments

@patilsuraj767
Copy link
Contributor

When executing feast materialize, the given timestamp is converted to the local timezone using astimezone(). This conversion appears redundant and somewhat confusing.

Expected Behavior

# feast materialize 2025-04-04T21:00:00 2025-04-05T15:00:00
Materializing 1 feature views from 2025-04-04 21:00:00 to 2025-04-05 15:00:00 into the postgres online store.

Current Behavior

# feast materialize 2025-04-04T21:00:00 2025-04-05T15:00:00
Materializing 1 feature views from 2025-04-05 02:30:00+05:30 to 2025-04-05 20:30:00+05:30 into the postgres online store.

Possible Solution

Removing .astimezone() from log statement.
@patilsuraj767
Copy link
Contributor Author

/assign

@patilsuraj767
Copy link
Contributor Author

If we agree that this conversion is indeed redundant, I’d love to raise my first PR in the Feast repo and contribute to fixing it. Looking forward to your thoughts!

@patilsuraj767 patilsuraj767 changed the title Redundant timezone conversion in feast materialize Redundant timezone conversion in feast materialize logs Apr 6, 2025
@patilsuraj767 patilsuraj767 mentioned this issue Apr 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug priority/p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Materialization logs patilsuraj767/feast
1 participant
@patilsuraj767