Skip to content

Workspace Symbols not including packages in vendor directory #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adevade opened this issue Aug 22, 2017 · 5 comments
Open

Workspace Symbols not including packages in vendor directory #467

adevade opened this issue Aug 22, 2017 · 5 comments

Comments

@adevade
Copy link

adevade commented Aug 22, 2017

OS: Windows 10
VS Code: 1.15.1 x64

I have a Laravel 5.5 app, and when I hit CTRL+T for Workspace Symbol search it doesn't include any files from the vendor directory except Composers own autoloader-files.

Here's some info from the Output->PHP Language Server tab

[Info  - 22:55:32] 74 Packages
[Info  - 22:55:32] Indexing laravel/framework for definitions and static 
..........
[Warn - 22:56:05] Could not compute cache key for laravel/framework
[Info  - 22:56:05] Restored nesbot/carbon:1.22.1 from cache
..........
[Info  - 22:56:07] All 4962 PHP files parsed in 36 seconds. 282 MiB allocated.

Here's without any search input. As you can see it loads my own files (in ./app and root directory) just fine.
code_2017-08-22_23-04-01

Here's when I search for Laravels Illuminate packages.
code_2017-08-22_23-04-39

Here's when I search for Carbon.
code_2017-08-22_23-04-56

Here's when I search for Composer.
code_2017-08-22_23-10-24

@duplicate-issues
Copy link

Hey @adevade,

We did a quick check and this issue looks very darn similar to

This could be a coincidence, but if any of these issues solves your problem then I did a good job 😄

If not, the maintainers will get to this issue shortly.

Cheers,
Your Friendly Neighborhood ProBot

@felixfbecker
Copy link
Owner

This is by design. workspace/symbol is designed to return the symbols defined in your own workspace. It would also be very slow to return all matches from dependencies.

@adamwathan
Copy link

This is by design. workspace/symbol is designed to return the symbols defined in your own workspace. It would also be very slow to return all matches from dependencies.

That's too bad 😕 Sublime handles this really well with no performance issues, would be awesome to have support for it in Code!

Thanks for all your hard work on these packages regardless, incredibly helpful stuff 👍

@hoangnamitc
Copy link

hoangnamitc commented Dec 10, 2017

excuse me, but my project.
If "new Class()" inside one file it working good, but if "new Class()" in other file after include it not working definition.

image

after:

image

@giulianoriccio
Copy link

@felixfbecker could this be made optional?
We could use the built-in option to exclude the path if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants