Fix PreparedStatement to set a unique name

PostgreSQL prepared statements and portals are referenced by names,
and using a hardcoded empty string as name may cause race conditions
when executing queries in parallel.

Author: davoclavo

src/main/scala/com/twitter/finagle/postgres/PostgresClientImpl.scala

@@ -155,7 +155,7 @@ class PostgresClientImpl(
     typeMap().flatMap { _ =>
       for {
         service   <- factory()
-        statement = new PreparedStatementImpl("", sql, service)
+        statement = new PreparedStatementImpl(sql, service)
         result    <- statement.select(params: _*)(f)
       } yield result
     }
@@ -168,7 +168,7 @@ class PostgresClientImpl(
     typeMap().flatMap { _ =>
       for {
         service   <- factory()
-        statement = new PreparedStatementImpl("", sql, service)
+        statement = new PreparedStatementImpl(sql, service)
         OK(count) <- statement.exec(params: _*)
       } yield count
     }
@@ -212,11 +212,12 @@ class PostgresClientImpl(
 
 
   private[this] class PreparedStatementImpl(
-    name: String,
     sql: String,
     service: Service[PgRequest, PgResponse]
   ) extends PreparedStatement {
 
+    private[this] val name = s"fin-pg-$id-" + counter.incrementAndGet
+
     def closeService = service.close()
 
     private[this] def parse(params: Param[_]*): Future[Unit] = {
@@ -302,8 +303,6 @@ class PostgresClientImpl(
       }.ensure(service.close())
     }
   }
-
-  private[this] def genName() = s"fin-pg-$id-" + counter.incrementAndGet
 }
 
 

version.sbt

@@ -1 +1 @@
-version in ThisBuild := "0.12.0-SNAPSHOT"
+version in ThisBuild := "0.12.1-SNAPSHOT"