You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DO NOT MERGE without reading.
This PR updates react to the new rc, and uses the new async act to silence a warning in ReactFinalForm.test.js
Further, regarding Field.test.js, I rewrote `sleep` with `act`, and discovered some issues, and disabled some tests -
'should use isEqual to calculate dirty/pristine': This test goes into an infinite loop; it appears act() has caught an actual bug here.
'should `formatOnBlur` most updated value' and 'should pass multiple through to custom components' appear to be breaking some assumptions for react-dom, and should probably be fixed.
I've included the warning messages that show for these warnings too.
it('should use isEqual to calculate dirty/pristine',()=>{
833
+
// Warning: Maximum update depth exceeded. This can happen when a component calls setState inside useEffect, but useEffect either doesn't have a dependency array, or one of the dependencies changes on every render.
834
+
// in Field (at Field.test.js:838)
835
+
// in form (at Field.test.js:837)
836
+
// in ReactFinalForm (at Field.test.js:835)
837
+
it.skip('should use isEqual to calculate dirty/pristine',()=>{
0 commit comments