Skip to content

Email link sign in button not shown when using custom layout #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rstjepanj opened this issue Dec 21, 2020 · 3 comments
Closed

Email link sign in button not shown when using custom layout #1885

rstjepanj opened this issue Dec 21, 2020 · 3 comments

Comments

@rstjepanj
Copy link

Step 1: Are you in the right place?

I believe so. Also, this problem seems to be a regression as it was already described and resolved in 1658

Step 2: Describe your environment

  • Android device: Pixel_3a_API_30_x86
  • Android OS version: 11
  • Google Play Services version: 19.0.0
  • Firebase/Play Services SDK version: 20.0.0
  • FirebaseUI version: 7.1.1

Step 3: Describe the problem:

When using custom layout and email link sign in the email button is not shown.

Steps to reproduce:

  1. Pull latest version of firebase-ui
  2. Create new firebase project with google sign in provider and email link provider
  3. Download google-services.json and put it in app directory
  4. Run the application and select AuthUI demo with layout radio button set to custom and providers set to Google and Email link
    Screenshot 2020-12-21 at 17 42 32

Observed Results:

The Email sign in button (textView) is not shown
Screenshot 2020-12-21 at 17 43 02

Expected Results:

I expected the email button to be shown

Relevant Code:

No code changes necessary.

Possible fix

Adding a new method setEmailLinkButtonId in AuthMethodPickerLayout and removing the method providerOrEmailLinkProvider as well as the one reference to it.
This is the solution I used to fix it locally so that I can use it on a project.

@sipersso
Copy link

sipersso commented Mar 9, 2021

Any workarounds for this one @samtstern? Will this be fixed? It's been a while since this was opened...

@sipersso
Copy link

6 months and no progress? No workaround?

@samtstern
Copy link
Contributor

This was fixed and released in version 7.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants