Skip to content

Commit 40e7a9c

Browse files
authored
ci: update contributing guide & automatically label issues that need attention (#401)
1 parent 0c497f8 commit 40e7a9c

File tree

3 files changed

+41
-1
lines changed

3 files changed

+41
-1
lines changed

Diff for: .github/workflows/issue-labels.yml

+34
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
name: Update labels on issues with OP response
2+
3+
on:
4+
issue_comment:
5+
types: [created]
6+
7+
jobs:
8+
label-op-response:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- name: Check if the comment is from the OP
12+
id: check-op
13+
run: |
14+
OP=${{ github.event.issue.user.login }}
15+
COMMENTER=${{ github.event.comment.user.login }}
16+
if [ "$OP" = "$COMMENTER" ]; then
17+
echo "op_comment=true" >> $GITHUB_ENV
18+
else
19+
echo "op_comment=false" >> $GITHUB_ENV
20+
fi
21+
- name: Add 'Needs Attention' label if OP responded
22+
if: env.op_comment == 'true'
23+
uses: actions-ecosystem/action-add-labels@v1
24+
with:
25+
labels: 'Needs Attention'
26+
env:
27+
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
28+
- name: Remove 'blocked customer-response' label if OP responded
29+
if: env.op_comment == 'true'
30+
uses: actions-ecosystem/action-remove-labels@v1
31+
with:
32+
labels: 'blocked: customer-response'
33+
env:
34+
GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}

Diff for: CONTRIBUTING.md

+6
Original file line numberDiff line numberDiff line change
@@ -145,6 +145,12 @@ Once the Firebase Emulator is up and running, execute the following Melos comman
145145
melos test:e2e
146146
```
147147

148+
If multiple devices are connected, you need to specify the target device by running the following command:
149+
150+
```bash
151+
melos test:e2e -- <device-id>
152+
```
153+
148154
Before submitting your PR, please provide evidence of running the E2E tests on macOS, Android, and iOS by sharing terminal output or screenshots. This demonstrates that the few E2E tests skipped in CI run successfully locally, which will enhance the review process for your PR.
149155

150156

Diff for: melos.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ scripts:
8181

8282
test:e2e:
8383
working-directory: tests
84-
run: flutter test integration_test/firebase_ui_test.dart -r github
84+
run: cd tests && flutter test integration_test/firebase_ui_test.dart -r github -d
8585

8686
# Additional cleanup lifecycle script, executed when `melos clean` is run.
8787
postclean: >

0 commit comments

Comments
 (0)