-
Notifications
You must be signed in to change notification settings - Fork 116
fix(ui_localizations): loading Traditional Chinese #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesnitsky
requested changes
Oct 5, 2023
@gary6lin Thanks for submitting a PR! Could you please add unit tests verifying that traditional Chinese loads correctly now? Also might be good to add a test verifying that localization overrides still work. Unit test under |
… the localization overrides work properly.
… the localization overrides work properly.
lesnitsky
approved these changes
Oct 9, 2023
lesnitsky
requested changes
Oct 9, 2023
packages/firebase_ui_localizations/test/firebase_ui_localizations_test.dart
Show resolved
Hide resolved
lesnitsky
requested changes
Oct 11, 2023
packages/firebase_ui_localizations/test/firebase_ui_localizations_test.dart
Outdated
Show resolved
Hide resolved
packages/firebase_ui_localizations/test/firebase_ui_localizations_test.dart
Outdated
Show resolved
Hide resolved
@gary6lin could you please run |
lesnitsky
requested changes
Oct 11, 2023
packages/firebase_ui_localizations/test/firebase_ui_localizations_test.dart
Outdated
Show resolved
Hide resolved
lesnitsky
approved these changes
Oct 11, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that the
firebase_ui_localizations
package includes a translation for Taiwan (ZhTWLocalizations
), but has not been used appropriately. So I follow the same approach of how theflutter_localizations
package gets the appropriate translation and how to fallback when thescriptCode
orcountryCode
is not defined.Related Issues
Closes #33
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?