Skip to content

fix(ui_localizations): loading Traditional Chinese #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 11, 2023

Conversation

LaemonT
Copy link
Contributor

@LaemonT LaemonT commented Oct 5, 2023

Description

I found that the firebase_ui_localizations package includes a translation for Taiwan (ZhTWLocalizations), but has not been used appropriately. So I follow the same approach of how the flutter_localizations package gets the appropriate translation and how to fallback when the scriptCode or countryCode is not defined.

Related Issues

Closes #33

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@LaemonT LaemonT changed the title Uses the way how _WidgetsLocalizationsDelegate choose an appropriate … Fixes [firebase_ui_localizations] loading Traditional Chinese Oct 5, 2023
@LaemonT LaemonT changed the title Fixes [firebase_ui_localizations] loading Traditional Chinese fix: [firebase_ui_localizations] loading Traditional Chinese Oct 5, 2023
@lesnitsky
Copy link
Member

lesnitsky commented Oct 5, 2023

@gary6lin Thanks for submitting a PR! Could you please add unit tests verifying that traditional Chinese loads correctly now? Also might be good to add a test verifying that localization overrides still work. Unit test under firebase_ui_localizations package should be fine.

@lesnitsky lesnitsky changed the title fix: [firebase_ui_localizations] loading Traditional Chinese fix(ui_localizations): loading Traditional Chinese Oct 5, 2023
@LaemonT LaemonT requested a review from lesnitsky October 5, 2023 23:50
@LaemonT LaemonT requested a review from lesnitsky October 9, 2023 17:08
@lesnitsky
Copy link
Member

@gary6lin could you please run melos run format to make code_health/format green.

@LaemonT LaemonT requested a review from lesnitsky October 11, 2023 14:45
@LaemonT LaemonT requested a review from lesnitsky October 11, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_ui_localizations] Traditional Chinese is not loading
2 participants