-
Notifications
You must be signed in to change notification settings - Fork 116
feat(ui_localizations): Add Norwegian (NB) localization #191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui_localizations): Add Norwegian (NB) localization #191
Conversation
@ovestoerholt could you please ask someone else who speaks Norwegian to proofread this PR and approve it? |
My native language is Norwegian and have proofread and can vouch for this translation. |
@ovestoerholt please also update |
@lesnitsky Added 👍 |
@@ -3,6 +3,8 @@ | |||
// BSD-style license that can be found in the LICENSE file. | |||
import 'dart:ui'; | |||
|
|||
import 'package:firebase_ui_localizations/src/lang/nb.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please follow the same style for imports as the rest of the languages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error - lib/src/lang/nb.dart:6:7 - Missing concrete implementations of 'getter FirebaseUILocalizationLabels.confirmDeleteAccountAlertMessage', 'getter FirebaseUILocalizationLabels.confirmDeleteAccountAlertTitle', and 'getter FirebaseUILocalizationLabels.confirmDeleteAccountButtonLabel'. Try implementing the missing methods, or make the class abstract. - non_abstract_class_inherits_abstract_member
Seems like there are a few missing keys.
Strange... Will have a look 👍 |
Ok. Found new additions in main. Will update 👍 |
@lesnitsky Please try now 👍 |
Description
Adds Norwegian localization.
Checklist
///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?