Skip to content

fix(firebase_ui_localizations): expose all Firebase UI localizations for overriding #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 19, 2024

Conversation

russellwheatley
Copy link
Member

Description

Expose all language localizations for FirebaseUI-Flutter so that users can override them if they wish.

Related Issues

fixes #302

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth): expose all Firebase UI localizations for overriding fix(firebase_ui_localizations): expose all Firebase UI localizations for overriding Mar 15, 2024
@russellwheatley russellwheatley merged commit e456747 into main Mar 19, 2024
14 of 16 checks passed
@russellwheatley russellwheatley deleted the localizations-302 branch March 19, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Overriding localization with special labels stops all other localizations
2 participants