-
Notifications
You must be signed in to change notification settings - Fork 116
feat(firebase_ui_localizations): Add Finnish language localization labels #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
BREAKING CHANGE New language added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you also get a Finnish language speaker to also approve the PR and I will get this merged. Thanks 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good as a Finnish speaking user. Just a couple of observations.
Correction of Finnish terms and spellings based on the comments given.
Added new statement to the file get_localization.dart, to which "switch and return" line related to the Finnish language was added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked latest changes to translations. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me too.
Approved by two native Finnish speakers. |
Reopened, can be closed when code changes are merged to main. |
Description
This PR adds new language Finnish. The translations are checked but not reviewed by third party.
The melos run analyze noticed error on the original main and these continued to be the same when I did with my changes,
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.melos run test:unit:all
doesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?