Skip to content

🐛 [flutterfire_ui] Missing localization in profile_screen #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
przemek-lagan opened this issue Sep 6, 2022 · 2 comments · Fixed by #87
Closed

🐛 [flutterfire_ui] Missing localization in profile_screen #54

przemek-lagan opened this issue Sep 6, 2022 · 2 comments · Fixed by #87
Assignees
Labels
auth localizations resolution: fixed A fix has been merged or is pending merge from a PR

Comments

@przemek-lagan
Copy link

Bug report

There are six hardcoded messages in english in profile_screen, concerning verification e-mail.
It is impossible to override them when making localization, that is not supported yet.

Steps to reproduce

Go to ProfileScreen with unverified account and locale other than English.
Look in profile_screen.dart for 'Email is not verified' strings etc.

Expected behavior

Strings should be replaced with labels (l.variablename).

Sample project

I've corrected the strings in my fork of flutterfire, but my solution lacks translations for supported languages.
Also, that could be a breaking change, as the labels are required, depending of localization method used.

@darshankawar
Copy link

Thanks for the report @przemek-lagan
I think there was an active PR to add localization https://github.com/firebase/flutterfire/pull/8366/files but seem to have been closed. You may keep an eye on it if it gets reopened.

I'll label this issue for now.

@lesnitsky lesnitsky self-assigned this Sep 16, 2022
@lesnitsky lesnitsky transferred this issue from firebase/flutterfire Aug 18, 2023
@SCarcalicea
Copy link

SCarcalicea commented Aug 30, 2023

Hey, are there any news about this change happening any time soon? I could address it based on the previous PR but I cannot push any changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auth localizations resolution: fixed A fix has been merged or is pending merge from a PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants