Skip to content

fix: update ru translations to remove English duplicates #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 22, 2023

Conversation

opimand
Copy link
Contributor

@opimand opimand commented Aug 21, 2023

Description

Elimination of duplicates in the Russian dictionary: removal of repetitive English words has been performed, as they are unnecessary for functionality.
Due to these duplicates, elements of the user interface appear overloaded, often resulting in overflow.
Screenshot 2023-08-21 at 17 34 09

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link
Member

@lesnitsky lesnitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update relevant .arb file and generate dart class from cli as mention in the contributing section of the docs

@opimand
Copy link
Contributor Author

opimand commented Aug 22, 2023

Please update relevant .arb file and generate dart class from cli as mention in the contributing section of the docs

I tried to run
run dart run firebase_ui_localizations:gen_l10n
as mentioned in the docs, but got an error every time

firebase_ui_localizations % flutter run firebase_ui_localizations:gen_l10n
Target file "firebase_ui_localizations:gen_l10n" not found.

May be I missunderstood something? I tried to do that at different directories, all posible I guess
Thats why I just generete .arb file by Android Studiio

@lesnitsky
Copy link
Member

cd packages/firebase_ui_localizations
dart run firebase_ui_localizations:gen_l10n
#^^^
# dart, not flutter

@opimand
Copy link
Contributor Author

opimand commented Aug 22, 2023

cd packages/firebase_ui_localizations
dart run firebase_ui_localizations:gen_l10n
#^^^
# dart, not flutter
firebase_ui_localizations % dart run firebase_ui_localizations:gen_l10n
Resolving dependencies in /Users/opimand/Documents/dev/FirebaseUI-Flutter/packages/firebase_ui_localizations... 
Because firebase_ui_localizations requires the Flutter SDK, version solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.

@lesnitsky lesnitsky merged commit 9d813be into firebase:main Aug 22, 2023
@lesnitsky
Copy link
Member

what does dart --version show for you? I suspect you have a flutter installation and a separate dart installation which is outdated, but that's just a wild guess.

@opimand
Copy link
Contributor Author

opimand commented Aug 22, 2023

art --version

 firebase_ui_localizations % dart --version
Dart SDK version: 3.0.7 (stable) (Mon Jul 24 13:17:56 2023 +0000) on "macos_arm64"

Works as usual...

lesnitsky pushed a commit to rstieger/FirebaseUI-Flutter that referenced this pull request Aug 24, 2023
* update translations (remove duplicates)

* update translations (remove duplicates)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants