Skip to content

fix(ui_auth): Pass correct AuthAction to the footerBuilder #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

MaximeRougieux
Copy link
Contributor

@MaximeRougieux MaximeRougieux commented Aug 23, 2023

Description

This change is needed to rebuild the footer when the action changes (for example when the user click on the header auth action switch)

Related Issues

None

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

This change is needed to rebuild the footer when the action changes (for example when the user click on the header auth action switch)
@google-cla
Copy link

google-cla bot commented Aug 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@lesnitsky lesnitsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add unit test verifying that this works

@lesnitsky lesnitsky changed the title fix: Wrong action value for authentication footer fix(ui_auth): Pass correct AuthAction to the footerBuilder Aug 23, 2023
@MaximeRougieux
Copy link
Contributor Author

Hey @lesnitsky, thanks for your quick review!
I pushed the test as asked.

Btw, sorry for the small detailed PR, I opened it in a rush. If you need more details on this, please feel free to ask 🙂

@lesnitsky
Copy link
Member

@MaximeRougieux could you please run melos run add-license-header?

@MaximeRougieux
Copy link
Contributor Author

@lesnitsky done!

@lesnitsky
Copy link
Member

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants