Skip to content

Commit 4e019f1

Browse files
feat(fcm): Exposed FCM APIs from firebase-admin/messaging entry point (#1153)
* feat(fcm): Exposed FCM APIs from firebase-admin/messaging entry point * Update src/messaging/messaging-api.ts Co-authored-by: Lahiru Maramba <[email protected]> Co-authored-by: Lahiru Maramba <[email protected]>
1 parent b865bf9 commit 4e019f1

13 files changed

+1914
-1627
lines changed

etc/firebase-admin.api.md

Lines changed: 126 additions & 271 deletions
Large diffs are not rendered by default.

etc/firebase-admin.messaging.api.md

Lines changed: 430 additions & 0 deletions
Large diffs are not rendered by default.

generate-reports.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ const entryPoints = {
3939
'firebase-admin/database': './lib/database/index.d.ts',
4040
'firebase-admin/firestore': './lib/firestore/index.d.ts',
4141
'firebase-admin/instance-id': './lib/instance-id/index.d.ts',
42+
'firebase-admin/messaging': './lib/messaging/index.d.ts',
4243
'firebase-admin/remote-config': './lib/remote-config/index.d.ts',
4344
};
4445

gulpfile.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,7 @@ gulp.task('compile', function() {
9292
'lib/database/*.d.ts',
9393
'lib/firestore/*.d.ts',
9494
'lib/instance-id/*.d.ts',
95+
'lib/messaging/*.d.ts',
9596
'lib/remote-config/*.d.ts',
9697
'!lib/utils/index.d.ts',
9798
];

src/app/firebase-app.ts

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ import { deepCopy } from '../utils/deep-copy';
2323
import { FirebaseNamespaceInternals } from './firebase-namespace';
2424
import { AppErrorCodes, FirebaseAppError } from '../utils/error';
2525

26-
import { Auth } from '../auth/auth';
26+
import { Auth } from '../auth/index';
2727
import { MachineLearning } from '../machine-learning/machine-learning';
28-
import { Messaging } from '../messaging/messaging';
28+
import { Messaging } from '../messaging/index';
2929
import { Storage } from '../storage/storage';
3030
import { Database } from '../database/index';
31-
import { Firestore } from '@google-cloud/firestore';
31+
import { Firestore } from '../firestore/index';
3232
import { InstanceId } from '../instance-id/index';
3333
import { ProjectManagement } from '../project-management/project-management';
3434
import { SecurityRules } from '../security-rules/security-rules';
@@ -293,10 +293,8 @@ export class FirebaseApp implements app.App {
293293
* @return The Messaging service instance of this app.
294294
*/
295295
public messaging(): Messaging {
296-
return this.ensureService_('messaging', () => {
297-
const messagingService: typeof Messaging = require('../messaging/messaging').Messaging;
298-
return new messagingService(this);
299-
});
296+
const fn = require('../messaging/index').getMessaging;
297+
return fn(this);
300298
}
301299

302300
/**

0 commit comments

Comments
 (0)