fix(auth): Fix several typing inconsistencies (#966)

* Perform several typing fixes

Author: MathBunny

src/auth/auth-config.ts

@@ -166,7 +166,7 @@ export interface EmailSignInConfigServerRequest {
  * to a format that is understood by the Auth server.
  */
 export class EmailSignInConfig implements EmailSignInProviderConfig {
-  public readonly enabled?: boolean;
+  public readonly enabled: boolean;
   public readonly passwordRequired?: boolean;
 
   /**

src/auth/auth.ts

@@ -107,6 +107,7 @@ export interface DecodedIdToken {
   picture?: string;
   sub: string;
   tenant?: string;
+  uid: string;
   [key: string]: any;
 }
 

src/auth/user-record.ts

@@ -148,7 +148,7 @@ export enum MultiFactorId {
  */
 export abstract class MultiFactorInfo {
   public readonly uid: string;
-  public readonly displayName: string | null;
+  public readonly displayName: string;
   public readonly factorId: MultiFactorId;
   public readonly enrollmentTime: string;
 
@@ -213,7 +213,7 @@ export abstract class MultiFactorInfo {
     }
     utils.addReadonlyGetter(this, 'uid', response.mfaEnrollmentId);
     utils.addReadonlyGetter(this, 'factorId', factorId);
-    utils.addReadonlyGetter(this, 'displayName', response.displayName || null);
+    utils.addReadonlyGetter(this, 'displayName', response.displayName);
     // Encoded using [RFC 3339](https://www.ietf.org/rfc/rfc3339.txt) format.
     // For example, "2017-01-15T01:30:15.01Z".
     // This can be parsed directly via Date constructor.
@@ -265,7 +265,7 @@ export class PhoneMultiFactorInfo extends MultiFactorInfo {
 
 /** Class representing multi-factor related properties of a user. */
 export class MultiFactor {
-  public readonly enrolledFactors: ReadonlyArray<MultiFactorInfo>;
+  public enrolledFactors: MultiFactorInfo[];
 
   /**
    * Initializes the MultiFactor object using the server side or JWT format response.

test/unit/auth/auth.spec.ts

@@ -161,6 +161,7 @@ function getDecodedIdToken(uid: string, authTime: Date, tenantId?: string): Deco
       sign_in_provider: 'custom', // eslint-disable-line @typescript-eslint/camelcase
       tenant: tenantId,
     },
+    uid,
   };
 }
 
@@ -186,6 +187,7 @@ function getDecodedSessionCookie(uid: string, authTime: Date, tenantId?: string)
       sign_in_provider: 'custom', // eslint-disable-line @typescript-eslint/camelcase
       tenant: tenantId,
     },
+    uid,
   };
 }
 

test/unit/auth/user-record.spec.ts

@@ -173,7 +173,7 @@ function getUserJSON(tenantId?: string): object {
         },
         {
           uid: 'enrollmentId2',
-          displayName: null,
+          displayName: undefined,
           enrollmentTime: now.toUTCString(),
           phoneNumber: '+16505556789',
           factorId: 'phone',
@@ -294,7 +294,7 @@ describe('PhoneMultiFactorInfo', () => {
   describe('getters', () => {
     it('should set missing optional fields to null', () => {
       expect(phoneMultiFactorInfoMissingFields.uid).to.equal(serverResponse.mfaEnrollmentId);
-      expect(phoneMultiFactorInfoMissingFields.displayName).to.be.null;
+      expect(phoneMultiFactorInfoMissingFields.displayName).to.be.undefined;
       expect(phoneMultiFactorInfoMissingFields.phoneNumber).to.equal(serverResponse.phoneInfo);
       expect(phoneMultiFactorInfoMissingFields.enrollmentTime).to.be.null;
       expect(phoneMultiFactorInfoMissingFields.factorId).to.equal('phone');
@@ -365,7 +365,7 @@ describe('PhoneMultiFactorInfo', () => {
     it('should return expected JSON object with missing fields set to null', () => {
       expect(phoneMultiFactorInfoMissingFields.toJSON()).to.deep.equal({
         uid: 'enrollmentId1',
-        displayName: null,
+        displayName: undefined,
         enrollmentTime: null,
         phoneNumber: '+16505551234',
         factorId: 'phone',